Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] upgrade to babel@7 #387

Merged
merged 2 commits into from
Dec 12, 2018
Merged

[internal] upgrade to babel@7 #387

merged 2 commits into from
Dec 12, 2018

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Dec 9, 2018

This PR upgrades vx packages to use babel 7. babel-upgrade does most of the heavy lifting. A huge help for a monorepo.

Thanks to @skevy for pointing out how painless the migration is which motivated me to do it.

Runbook

For each package:

  1. npx babel-upgrade --write info
  2. remove external-helpers from rollup.config.js rollup-plugin-babel for babel 7 now dedups helpers
  3. update build:babel cmd to babel 7 plugins
  4. update rollup version to 0.67.4
  5. rm -rf ./node_modules
  6. npm install
  7. npm run test

Testing

Changelog

📝 Documentation

  • [gallery] add <BarStackHorizontal /> example code back

🏠 Internal

@hshoff hshoff added this to the v0.0.182 milestone Dec 9, 2018
@williaster
Copy link
Collaborator

woot! nice 👌 I did this for @data-ui recently and it was a bit painful ... mostly beemo learning curve. glad babel-upgrade made it easier!

@hshoff hshoff merged commit c503c3d into master Dec 12, 2018
@hshoff hshoff deleted the harry-babel7 branch December 12, 2018 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants