[legend][scale] add @vx/legend, add additional scales fixes #65 #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hshoff
changed the title
williaster
reviewed
Jun 16, 2017
| <div | ||
| className={cx('vx-legend', className)} | ||
| style={style} | ||
| style={{ |
There was a problem hiding this comment.
not sure if this is intentional but looks like the passed style would be overridden here? I think passing styles would be solid though, then you could flex-wrap vs not, etc.
There was a problem hiding this comment.
not intentional, i've got this fixed locally, just haven't pushed it yet. Good catch! 👍
|
Update:
custom shapes
Almost there. |
|
closing in favor of #77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
@vx/scalescaleQuantize()scaleQuantile()scaleThreshold()@vx/legend<LegendLinear /><LegendOrdinal /><LegendQuantile /><LegendThreshold />view source
@vx/legenduses HTML instead of SVG. Benefits of HTML for legends includes using flexbox for layout and easy to add controls like checkboxes, sliders, selects, etc.Need to add:
<LegendSize />shapeprop should be one ofrect | circle | Element | functionfixes #65