new(vx-demo): convert LinkTypes to codesandbox #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
May 12, 2020
| } | ||
| } | ||
|
|
||
| const LinkComponent = getLinkComponent({ layout, linkType, orientation }); |
There was a problem hiding this comment.
just moved to new file
williaster
commented
May 12, 2020
|
|
||
| return totalWidth < 10 ? null : ( | ||
| <div> | ||
| <LinkControls |
There was a problem hiding this comment.
just moved to new file
williaster
force-pushed
the
chris--sandbox-linktypes
branch
from
7bb941b
to
108e6f4
Compare
hshoff
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Documentation
🏠 Internal
Part of #624 (the last PR!), re-writes the
LinkTypesdemo to link out to code-sandbox. To clean up the example code I refactored some of the code to separate components.Link (update branch to master upon merge).
@kristw @hshoff