Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Axis): tick index = post-filtered index #818

Merged
merged 3 commits into from
Sep 30, 2020
Merged

fix(Axis): tick index = post-filtered index #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95c28c4
fix(Axis): tick index = post-filtered index
williaster Sep 29, 2020
8635ddf
test(Axis): fix hideZero test
williaster Sep 29, 2020
8ffcfef
fix(demo/threshold): undo oops commit
williaster Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/visx-axis/src/axis/Axis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export default function Axis<Scale extends AxisScale>({
);

const filteredTickValues = (tickValues ?? getTicks(scale, numTicks))
.map((value, index) => ({ value, index }))
.filter(({ value }) => !hideZero || (value !== 0 && value !== '0'));
.filter(value => !hideZero || (value !== 0 && value !== '0'))
.map((value, index) => ({ value, index }));

const ticks = filteredTickValues.map(({ value, index }) => {
const scaledValue = coerceNumber(tickPosition(value));
Expand Down
2 changes: 1 addition & 1 deletion packages/visx-axis/test/Axis.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ describe('<Axis />', () => {
.find('.visx-axis-tick')
.at(0)
.key(),
).toBe('visx-tick-1-1');
).toBe('visx-tick-1-0');
});

test('it should SHOW an axis line if hideAxisLine is false', () => {
Expand Down