-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(responsive): add ignoreDimensions
prop to handle rerenders
#834
Conversation
Pull Request Test Coverage Report for Build 293585828
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the addition @wyze, and the FunctionComponent
refactor! 💯
I had a couple of small suggestions but otherwise lgtm. I think for now don't worry about new tests, mocking these things in enzyme isn't super easy / I can add the boilerplate later.
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
disableFor
prop to handle rerendersignoreDimensions
prop to handle rerenders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the addition @wyze!
🚀 Enhancements
This PR
disableFor
) to skip when a component doesn't want to be notified by a size change of a certain propNote: I did attempt a test and was unsuccessful, so more than happy to add one provided some direction. I use react-testing-library, so unsure how to simulate resize of an element with enzyme.
Also,disableFor
might not be the best name for the prop, so I am open to changing it.Close #247