Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication #838

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Conversation

anastasiia-gontarieva
Copy link
Contributor

@anastasiia-gontarieva anastasiia-gontarieva commented Oct 2, 2020

🏠 Internal

The body of this case clause on a line 26 duplicates the body of this case clause on a line 14. This may be caused by a copy-paste error. If this usage is intentional, consider using fall-through to remove code duplication.

The body of this case clause on a line 26 duplicates the body of this case clause on a line 14. This may be caused by a copy-paste error. If this usage is intentional, consider using fall-through to remove code duplication.
@coveralls
Copy link

coveralls commented Oct 2, 2020

Pull Request Test Coverage Report for Build 285622952

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 55.301%

Files with Coverage Reduction New Missed Lines %
packages/visx-pattern/src/patterns/Lines.tsx 1 85.0%
Totals Coverage Status
Change from base Build 283122090: 0.04%
Covered Lines: 1152
Relevant Lines: 2027

💛 - Coveralls

@williaster
Copy link
Collaborator

Hi @anastasiia-gontarieva thanks for the PR. Happy to incorporate this, but for readability let's keep the case you removed and just merge it with the default. something like

case PatternOrientation.vertical:
default:
  return `M ${height / 2}, 0 l 0, ${height}`;

@anastasiia-gontarieva
Copy link
Contributor Author

@williaster thanks. I made suggested changes. Could you please have a look when you have a free sec and checks have completed?

Copy link
Member

@hshoff hshoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the contribution!

@hshoff hshoff added this to the 1.0.1 milestone Oct 5, 2020
@hshoff hshoff merged commit cc85c71 into airbnb:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants