-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stats): update min/max in computeStats to handle no outliers #853
Conversation
Pull Request Test Coverage Report for Build 118
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix @kanhegaonkarsaurabh! this looks good to me except the build is failing due to a prettier issue I commented on.
@@ -1,22 +1,28 @@ | |||
import { computeStats } from '../src'; | |||
import { computeStats } from "../src"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the addition of double quotes throughout here is failing prettier
in the build. you can update them manually or run yarn format
from the monorepo root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had an issue running yarn format
due to a nimbus
driver not found error. Thus, I ended up doing it manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting, should work if you run yarn
in the root to install all deps. in any case glad you got it!
@williaster Got it! I've updated the test file to include single quotes and fix the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution @kanhegaonkarsaurabh 🙌 !
🐛 Bug fix
Closes #851.