fix(tooltip): fallback to left/top positioning, add applyPositionStyle #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Oct 8, 2020
| React.HTMLProps<HTMLDivElement> & | ||
| WithBoundingRectsProps; | ||
|
|
||
| function TooltipWithBounds({ | ||
| children, |
williaster
commented
Oct 8, 2020
| @@ -2,13 +2,26 @@ import React from 'react'; | |||
| import cx from 'classnames'; | |||
|
|
|||
| export type TooltipProps = { | |||
| children?: React.ReactNode; | |||
Pull Request Test Coverage Report for Build 294468908
💛 - Coveralls |
kristw
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This partially reverts #828 (which fixed #767) because the re-implementation of in
Tooltipto usetransforminstead oftop/leftfor positioning breaks cases where users themselves setstyle.transformand would thus be a 💥 breaking change. This was true in the/areasdemo:Before
After
🚀 Enhancements
@visx/tooltipapplyPositionStylewhich appliesposition: absoluteso that users who setunstyled=truedon't have to set this themselves via a CSS selector 🤦 . In a future breaking change this will be the default behavior.@hshoff @kristw