Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(annotation): add tests for new annotation components #912

Merged
merged 2 commits into from
Nov 6, 2020
Merged

test(annotation): add tests for new annotation components #912

merged 2 commits into from
Nov 6, 2020

Conversation

williaster
Copy link
Collaborator

🏠 Internal

Adds tests to @visx/annotation components introduced in #907

@kristw @hshoff

@williaster williaster added this to the 1.1.1 milestone Nov 3, 2020
@coveralls
Copy link

coveralls commented Nov 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 348523410

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.8%) to 60.809%
Totals Coverage Status
Change from base Build 348517765: 2.8%
Covered Lines: 1630
Relevant Lines: 2533
💛 - Coveralls

@williaster williaster changed the base branch from chris--new-annotations-demo to chris--new-annotations November 3, 2020 22:15
Base automatically changed from chris--new-annotations to master November 5, 2020 23:14
@williaster williaster merged commit 519d92d into master Nov 6, 2020
@williaster williaster deleted the chris--new-annotations-tests branch November 6, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw Awaiting requested review from kristw

Assignees
No one assigned
Labels
🏠 internal @visx/annotation
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@williaster @coveralls @hshoff