fix(shape): conditionally render Arc without data #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This supersedes #892 and partially addresses #886, it
@visx/shape
sArc
when nodata
is specified if angles + radii are specifiednull
due to missingdata
+ angles + radii for better dev experienceAs mentioned in both issues above, d3-shape supports two types of usage for
arc()
, it can be configured with constant angles + radii, or passed them (asdata
in@visx/shape
):@hshoff @kristw
cc @oscar-broman @thecodeah