Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(xychart): add PointerEvent tests #952

Merged
merged 2 commits into from
Dec 3, 2020
Merged

test(xychart): add PointerEvent tests #952

merged 2 commits into from
Dec 3, 2020

Conversation

williaster
Copy link
Collaborator

🏠 Internal

This PR adds PointerEvent handler tests for the functionality added in #947 :

image
image
image

@hshoff @kristw

@williaster williaster added this to the 1.2.1 milestone Dec 1, 2020
@williaster williaster mentioned this pull request Dec 1, 2020
Merged
1 task
Base automatically changed from chris--xychart-handlers to master December 3, 2020 20:05
@williaster williaster force-pushed the chris--xychart-pointerevent-tests branch from bdee971 to 2508548 Compare December 3, 2020 20:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 399198231

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 61.371%
Totals Coverage Status
Change from base Build 399195855: 0.1%
Covered Lines: 1712
Relevant Lines: 2621
💛 - Coveralls

@williaster williaster merged commit 4c82b1c into master Dec 3, 2020
@williaster williaster deleted the chris--xychart-pointerevent-tests branch December 3, 2020 20:39
@williaster williaster modified the milestones: 1.2.1, 1.3.0 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hshoff hshoff hshoff approved these changes

@kristw kristw Awaiting requested review from kristw

Assignees
No one assigned
Labels
🏠 internal
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@williaster @coveralls @hshoff