Skip to content

Commit

Permalink
fix: xor with --chart and --chart-version flags (#130)
Browse files Browse the repository at this point in the history
  • Loading branch information
abuchanan-airbyte authored Oct 8, 2024
1 parent 23f0fd6 commit 4ec1013
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions internal/cmd/local/local_install.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (

type InstallCmd struct {
Chart string `help:"Path to chart." xor:"chartver"`
ChartVersion string `default:"latest" help:"Version to install." xor:"chartver"`
ChartVersion string `help:"Version to install." xor:"chartver"`
DockerEmail string `group:"docker" help:"Docker email." env:"ABCTL_LOCAL_INSTALL_DOCKER_EMAIL"`
DockerPassword string `group:"docker" help:"Docker password." env:"ABCTL_LOCAL_INSTALL_DOCKER_PASSWORD"`
DockerServer string `group:"docker" default:"https://index.docker.io/v1/" help:"Docker server." env:"ABCTL_LOCAL_INSTALL_DOCKER_SERVER"`
Expand Down Expand Up @@ -133,10 +133,6 @@ func (i *InstallCmd) Run(ctx context.Context, provider k8s.Provider, telClient t
InsecureCookies: i.InsecureCookies,
}

if opts.HelmChartVersion == "latest" {
opts.HelmChartVersion = ""
}

if err := lc.Install(ctx, opts); err != nil {
spinner.Fail("Unable to install Airbyte locally")
return err
Expand Down

0 comments on commit 4ec1013

Please sign in to comment.