feat: --chart flag #121
Merged
feat: --chart flag #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesnodgrass
requested changes
Sep 18, 2024
internal/cmd/local/local/install.go
Outdated
| @@ -42,6 +42,7 @@ const ( | |||
| ) | |||
|
|
|||
| type InstallOpts struct { | |||
| HelmChartFlag string | |||
There was a problem hiding this comment.
Something looks weird with the formatting here, can you verify that this was formatted?
internal/cmd/local/local_install.go
Outdated
| @@ -101,6 +102,7 @@ func (i *InstallCmd) Run(ctx context.Context, provider k8s.Provider, telClient t | |||
| } | |||
|
|
|||
| opts := local.InstallOpts{ | |||
| HelmChartFlag: i.Chart, | |||
|
Also can you update the |
colesnodgrass
approved these changes
Sep 18, 2024
|
I think the XOR is broken:
|
|
Thanks @stephanbertl . Hopefully #130 will address that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--chartallows using a specific chart, such as a local chart directory (--chart /Users/alexbuchanan/dev/dev-chart)I've been hacking a local chart path into my abctl code to do development with a local chart directory.