fix: don't pass context to segment telemetry #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +149,7 @@ func (s *SegmentClient) send(ctx context.Context, es EventState, et EventType, e | |||
| return fmt.Errorf("unable to create request body: %w", err) | |||
| } | |||
|
|
|||
| req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, bytes.NewBuffer(data)) | |||
| req, err := http.NewRequest(http.MethodPost, url, bytes.NewBuffer(data)) | |||
There was a problem hiding this comment.
What if we only made this change, but still passed the context through everything?
There was a problem hiding this comment.
I'm thinking about this in a similar way that the go slog package handles cancelled contexts, in that they ignore them in certain cases; e.g.
The signature of Handle is
Handle(context.Context, Record) errorThe context is provided to support applications that provide logging information along the call chain. In a break with usual Go practice, the Handle method should not treat a canceled context as a signal to stop work.
There was a problem hiding this comment.
Sure, that's a good idea.
|
Closed in favor of #139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user cancels an install by pressing Ctrl+C, the Go Context created in main.go is canceled. That context was being passed to the Segment telemetry client, which was trying to send an HTTP request using the canceled context, which would always fail. That resulted in a surprisingly large number of 'running' events.
This change removes the context from the telemetry client calls so that this doesn't happen.