Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deployments command failing #144

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

colesnodgrass
Copy link
Member

  • fix the error couldn't find binding of type k8s.Client for parameter 2 of func(context.Context, telemetry.Client, k8s.Client) error(), use kong.Bind(k8s.Client)
    • moved the defaultK8s method from local_credentials to local and called the method from the deployments command

@colesnodgrass colesnodgrass requested a review from a team as a code owner October 31, 2024 21:33
@colesnodgrass colesnodgrass merged commit 91789e6 into main Oct 31, 2024
2 checks passed
@colesnodgrass colesnodgrass deleted the cole/fix-deployments-cmd branch October 31, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants