Changes some PATs to be from user AIRBYTEIO #11295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce reliance on Davin's personal token
|
|
supertopher
commented
Mar 21, 2022
| @@ -103,7 +103,8 @@ jobs: | |||
| run: | | |||
| mkdir -p ~/.gradle/ | |||
| cat > ~/.gradle/gradle.properties <<EOF | |||
| org.gradle.jvmargs=-Xmx8g -Xss4m --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \ | |||
| org.gradle.jvmargs=-Xmx8g -Xss4m \ | |||
| --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \ | |||
There was a problem hiding this comment.
this is unrelated and a nit, please tell me to fork off for coding standards here if that's how we roll
|
Failed test from API limits ☝️ |
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase effective API limit
Reduce reliance on Davin's personal token
What
More token for more API limits
Tokens are repo level. A separate token exists for OSS and for Cloud
How
Add secret to GH GUI
Use corresponding secret
Recommended reading order
any order you like for 5 lines
🚨 User Impact 🚨
None (probably :)
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Tested token and workflow in cloud. Working as intended