build acceptance test connector images for m1 #11374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmossman
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
This seems fine to me. I only have one nit, which is that this script should probably not have the name m1 in it, because it only builds an M1 image if it is ran on an M1 laptop, so something like rebuild_acceptance_test_connector_images_locally.sh might be more fitting. Definitely a small nit though.
|
Also, a comment at the top of the script explaining its purpose would be helpful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been seeing a ton of issues with hanging calls to connectors in local acceptance tests when developing with M1.
Now using
./tools/bin/build_acceptance_test_connector_images_m1.shyou'll end up with the same versions inmasterand they should be more stable for local development.We'll have to manually bump here if we ever upgrade off of the incompatible
0.1.1to0.2.xfor the acceptance tests. It seems more likely that we'll have actual matrix builds by then, so I think this is a fine compromise.