SAT: check oneOf common property has only `const` keyword, no `default` and `enum` keywords #11704

grubberr · 2022-04-04T19:34:50Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Improve TestSpec.test_oneof_usage SAT test - check oneOf common property has only const keyword and no more default and enum keywords.
Keywords default and enum are redundant, add more confusion and can be source of errors.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the new connector version is published, connector version bumped in the seed directory as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-04T20:38:30Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2092393684
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2092393684
No Python unittests run

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-06T09:19:24Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2101497286
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2101497286
No Python unittests run

grubberr · 2022-04-06T09:19:24Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2101497170
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2101497170
No Python unittests run

codecov · 2022-04-06T09:23:57Z

Codecov Report

❗ No coverage uploaded for pull request base (master@d778ac7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11704   +/-   ##
=========================================
  Coverage          ?   70.46%           
=========================================
  Files             ?       13           
  Lines             ?      877           
  Branches          ?        0           
=========================================
  Hits              ?      618           
  Misses            ?      259           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d778ac7...7c53696. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-06T18:58:02Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2104485651
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2104485651
No Python unittests run

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py

…tance_test/tests/test_core.py Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-04-07T07:13:47Z

/test connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2107291237
✅ bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2107291237
No Python unittests run

grubberr · 2022-04-07T07:21:09Z

/publish connector=bases/source-acceptance-test

🕑 bases/source-acceptance-test https://github.com/airbytehq/airbyte/actions/runs/2107327192
🚀 Successfully published bases/source-acceptance-test
❌ Couldn't auto-bump version for bases/source-acceptance-test

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

improve test_oneof_usage

8169f4a

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr linked an issue Apr 4, 2022 that may be closed by this pull request

SAT: check oneOf common property has only const keyword, no default and enum keywords #11703

Closed

grubberr self-assigned this Apr 5, 2022

grubberr added 2 commits April 6, 2022 07:38

Merge branch 'master' into grubberr/11703-source-acceptance-test

ff71102

test_oneof_usage improved

6da5d8f

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr added 3 commits April 6, 2022 18:38

Merge branch 'master' into grubberr/11703-source-acceptance-test

9c4978b

test_oneof_usage improved

5a734e3

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

CHANGELOG.md updated

1d4526b

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr changed the title ~~SAT: improve test_oneof_usage common_prop const equals default~~ SAT: check oneOf common property has only const keyword, no default and enum keywords Apr 6, 2022

connector-specification-reference.md updated

822ac32

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Apr 6, 2022

grubberr requested review from sherifnada and midavadim April 6, 2022 18:58

sherifnada approved these changes Apr 7, 2022

View reviewed changes

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py Outdated Show resolved Hide resolved

airbyte-integrations/bases/source-acceptance-test/source_acceptance_test/tests/test_core.py Outdated Show resolved Hide resolved

grubberr and others added 4 commits April 7, 2022 10:07

Update airbyte-integrations/bases/source-acceptance-test/source_accep…

42c0c3c

…tance_test/tests/test_core.py Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

Update airbyte-integrations/bases/source-acceptance-test/source_accep…

d5ecd9a

…tance_test/tests/test_core.py Co-authored-by: Sherif A. Nada <snadalive@gmail.com>

Merge branch 'master' into grubberr/11703-source-acceptance-test

db25173

fix syntax error

7c53696

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

black code

e64bce7

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr merged commit 6092bee into master Apr 7, 2022

grubberr deleted the grubberr/11703-source-acceptance-test branch April 7, 2022 07:40

This was referenced Apr 8, 2022

Bump Airbyte version from 0.35.65-alpha to 0.35.66-alpha #11839

Closed

Bump Airbyte version from 0.35.65-alpha to 0.35.66-alpha #11851

Closed

This was referenced Apr 8, 2022

Bump Airbyte version from 0.35.65-alpha to 0.35.66-alpha #11862

Closed

Bump Airbyte version from 0.35.65-alpha to 0.35.66-alpha #11920

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SAT: check oneOf common property has only `const` keyword, no `default` and `enum` keywords #11704

SAT: check oneOf common property has only `const` keyword, no `default` and `enum` keywords #11704

grubberr commented Apr 4, 2022 •

edited

Loading

grubberr commented Apr 4, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 6, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 6, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 6, 2022 •

edited

Loading

grubberr commented Apr 6, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2022 •

edited by github-actions bot

Loading

SAT: check oneOf common property has only const keyword, no default and enum keywords #11704

SAT: check oneOf common property has only const keyword, no default and enum keywords #11704

Conversation

grubberr commented Apr 4, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Apr 4, 2022 • edited by github-actions bot Loading

grubberr commented Apr 6, 2022 • edited by github-actions bot Loading

grubberr commented Apr 6, 2022 • edited by github-actions bot Loading

codecov bot commented Apr 6, 2022 • edited Loading

Codecov Report

grubberr commented Apr 6, 2022 • edited by github-actions bot Loading

grubberr commented Apr 7, 2022 • edited by github-actions bot Loading

grubberr commented Apr 7, 2022 • edited by github-actions bot Loading

SAT: check oneOf common property has only `const` keyword, no `default` and `enum` keywords #11704

SAT: check oneOf common property has only `const` keyword, no `default` and `enum` keywords #11704

grubberr commented Apr 4, 2022 •

edited

Loading

grubberr commented Apr 4, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 6, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 6, 2022 •

edited by github-actions bot

Loading

codecov bot commented Apr 6, 2022 •

edited

Loading

grubberr commented Apr 6, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2022 •

edited by github-actions bot

Loading

grubberr commented Apr 7, 2022 •

edited by github-actions bot

Loading