fix race condition in port reintroduction test #11735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
davinchia
reviewed
Apr 5, 2022
| } | ||
|
|
||
| doneTakingPorts.countDown(); |
There was a problem hiding this comment.
how does the latch help this?
There was a problem hiding this comment.
We wait on this assertTrue(doneTakingPorts.await(5, TimeUnit.SECONDS));
What this allows us to do is handle the case where it was taking an additional element in the thread before draining. Now it actually waits for the thread to complete using this mechanism so we guarantee the thread isn't touching the portsTaken list.
There was a problem hiding this comment.
Got it. Pity. I thought this would help with the socket hanging issue we are seeing.
davinchia
approved these changes
Apr 5, 2022
|
I ran this a bunch of times and it works at least way more commonly. |
jrhizor
deleted the
jrhizor/fix-race-condition-in-port-reintroduction-test
branch
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9650 (comment)
This locks properly around accessing the ports now. The problem before was that it could be in the middle of a
takein the background thread when it wasn't supposed to be.