Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sidebar Popout for Support Links #11745

Merged
merged 7 commits into from
Apr 6, 2022
Merged

Conversation

teallarson
Copy link
Contributor

@teallarson teallarson commented Apr 5, 2022

What

Addresses #11187 by adding a "Support" sidebar menu with links to Intercom chat and our support ticket portal.

New menu popout expanded:
Screen Shot 2022-04-06 at 9 36 37 AM

OSS menu expanded (does not contain the new items, new positioning works ok for now)
Screen Shot 2022-04-06 at 9 40 12 AM

Decided against a more elegant method for adjusting positioning and such as we plan to refactor the sidebar entirely in the near future.

How

  • Renames ResourcePopup to more accurate SidebarPopout and refactors styling slightly
  • Adds a second SidebarPopout to the Cloud UI with Submit a Ticket and Chat With Us (shown below)

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Apr 5, 2022
@teallarson teallarson changed the title add popout for support section Add Sidebar Popout for Support Links Apr 5, 2022
@teallarson teallarson marked this pull request as ready for review April 6, 2022 17:19
@teallarson teallarson requested a review from a team as a code owner April 6, 2022 17:19
@teallarson teallarson force-pushed the teal-integrate-support-portal branch from b1474fb to b4c2152 Compare April 6, 2022 17:29
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 6, 2022
@teallarson teallarson temporarily deployed to more-secrets April 6, 2022 17:31 Inactive
@teallarson teallarson temporarily deployed to more-secrets April 6, 2022 17:31 Inactive
@teallarson teallarson marked this pull request as draft April 6, 2022 17:37
@teallarson teallarson force-pushed the teal-integrate-support-portal branch from b4c2152 to b1474fb Compare April 6, 2022 17:44
@github-actions github-actions bot removed area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Apr 6, 2022
@teallarson teallarson marked this pull request as ready for review April 6, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants