🎉 Source Amazon Ads: improve docs for beta #12541

grubberr · 2022-05-03T17:55:17Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Improve documentation for Beta

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

codecov · 2022-05-03T18:02:12Z

Codecov Report

❗ No coverage uploaded for pull request base (master@c96f32f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12541   +/-   ##
=========================================
  Coverage          ?   98.79%           
=========================================
  Files             ?       22           
  Lines             ?      663           
  Branches          ?        0           
=========================================
  Hits              ?      655           
  Misses            ?        8           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c96f32f...5e9b87b. Read the comment docs.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-05-04T18:41:53Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2271664815
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2271664815
🐛

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-05-04T19:01:23Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2271754566
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2271754566
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            28      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               663      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 650.02s (0:10:50) ===================

…ccount" Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

CLAassistant · 2022-05-05T13:07:56Z

All committers have signed the CLA.

Signed-off-by: Serhii Chvaliuk <grubberr@gmail.com>

grubberr · 2022-05-08T04:23:05Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2288503549
❌ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2288503549
🐛 https://gradle.com/s/lhxg5osqzoqh4
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Timeout >300.0s
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
============= 1 failed, 22 passed, 1 skipped in 856.43s (0:14:16) ==============

grubberr · 2022-05-08T05:22:32Z

/test connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2288627168
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2288627168
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                                                              Stmts   Miss  Cover
-------------------------------------------------------------------------------------
source_amazon_ads/streams/sponsored_products.py                      32      0   100%
source_amazon_ads/streams/sponsored_display.py                       22      0   100%
source_amazon_ads/streams/sponsored_brands.py                        17      0   100%
source_amazon_ads/streams/report_streams/products_report.py          19      0   100%
source_amazon_ads/streams/report_streams/display_report.py           16      0   100%
source_amazon_ads/streams/report_streams/brands_video_report.py      10      0   100%
source_amazon_ads/streams/report_streams/brands_report.py            10      0   100%
source_amazon_ads/streams/report_streams/__init__.py                  5      0   100%
source_amazon_ads/streams/profiles.py                                21      0   100%
source_amazon_ads/streams/__init__.py                                 6      0   100%
source_amazon_ads/spec.py                                            28      0   100%
source_amazon_ads/schemas/sponsored_products.py                      37      0   100%
source_amazon_ads/schemas/sponsored_display.py                       31      0   100%
source_amazon_ads/schemas/sponsored_brands.py                        22      0   100%
source_amazon_ads/schemas/profile.py                                 16      0   100%
source_amazon_ads/schemas/common.py                                  45      0   100%
source_amazon_ads/schemas/__init__.py                                 6      0   100%
source_amazon_ads/constants.py                                        7      0   100%
source_amazon_ads/__init__.py                                         2      0   100%
source_amazon_ads/streams/common.py                                  77      1    99%
source_amazon_ads/source.py                                          34      1    97%
source_amazon_ads/streams/report_streams/report_streams.py          200      6    97%
-------------------------------------------------------------------------------------
TOTAL                                                               663      8    99%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 222.57s (0:03:42) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-05-08T05:56:11Z

/publish connector=connectors/source-amazon-ads

🕑 connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2288696866
🚀 Successfully published connectors/source-amazon-ads
🚀 Auto-bumped version for connectors/source-amazon-ads
✅ connectors/source-amazon-ads https://github.com/airbytehq/airbyte/actions/runs/2288696866

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

bump version

6812dd0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr self-assigned this May 3, 2022

github-actions bot added the area/connectors Connector related issues label May 3, 2022

grubberr linked an issue May 3, 2022 that may be closed by this pull request

🎉 Source Amazon Ads: improve docs for beta #12540

Closed

grubberr added 2 commits May 3, 2022 22:21

Merge branch 'master' into grubberr/issue-12540-source-amazon-ads

d2306d5

update amazon-ads.md

57af2de

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label May 4, 2022

grubberr added 12 commits May 4, 2022 09:44

Supported sync modes - added

d8595dd

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

continue to improve

545456f

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Prerequisites added

ed0fe0c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

continue to improve

1c225b5

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

simplify Data type mapping

0a33c9c

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

move start date to top

1b36199

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Report Wait Timeout, Report Generation Maximum Retries - added

a1ff873

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

all steps are done

b0038cc

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

For Airbyte OSS added

258b187

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix typos

bd426e4

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix typos (2)

5b568e3

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

reportDate added

9862255

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr mentioned this pull request May 4, 2022

[EPIC] Source Amazon Ads to Cloud Beta #11028

Closed

7 tasks

changelog updated

ed28489

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested review from misteryeo and removed request for misteryeo May 4, 2022 18:59

grubberr requested a review from misteryeo May 4, 2022 19:01

grubberr added 2 commits May 4, 2022 23:34

Merge branch 'master' into grubberr/issue-12540-source-amazon-ads

d0fd79d

bugfix "Authenticate your account" -> "Authenticate your Amazon Ads a…

cf77089

…ccount" Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

misteryeo approved these changes May 4, 2022

View reviewed changes

Merge branch 'master' into grubberr/issue-12540-source-amazon-ads

926d1f8

Signed-off-by: Serhii Chvaliuk <grubberr@gmail.com>

grubberr added 3 commits May 8, 2022 08:31

Merge branch 'master' into grubberr/issue-12540-source-amazon-ads

ab86623

improve docs

034cae0

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix docs

7847aa7

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

auto-bump connector version

5e9b87b

octavia-squidington-iii temporarily deployed to more-secrets May 8, 2022 06:18 Inactive

grubberr merged commit 886da80 into master May 8, 2022

grubberr deleted the grubberr/issue-12540-source-amazon-ads branch May 8, 2022 06:46

grubberr linked an issue May 8, 2022 that may be closed by this pull request

[EPIC] Source Amazon Ads to Cloud Beta #11028

Closed

7 tasks

This was unlinked from issues May 8, 2022

🎉 Source Amazon Ads: improve docs for beta #12540

Closed

[EPIC] Source Amazon Ads to Cloud Beta #11028

Closed

grubberr linked an issue May 8, 2022 that may be closed by this pull request

🎉 Source Amazon Ads: improve docs for beta #12540

Closed

octavia-squidington-iii mentioned this pull request May 9, 2022

Bump Airbyte version from 0.37.0-alpha to 0.37.1-alpha #12703

Merged

suhomud pushed a commit that referenced this pull request May 23, 2022

🎉 Source Amazon Ads: improve docs for beta (#12541)

8f76229

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source Amazon Ads: improve docs for beta #12541

🎉 Source Amazon Ads: improve docs for beta #12541

grubberr commented May 3, 2022 •

edited

Loading

codecov bot commented May 3, 2022 •

edited

Loading

grubberr commented May 4, 2022 •

edited by github-actions bot

Loading

grubberr commented May 4, 2022 •

edited by github-actions bot

Loading

CLAassistant commented May 5, 2022 •

edited

Loading

grubberr commented May 8, 2022 •

edited by github-actions bot

Loading

grubberr commented May 8, 2022 •

edited by github-actions bot

Loading

grubberr commented May 8, 2022 •

edited by github-actions bot

Loading

🎉 Source Amazon Ads: improve docs for beta #12541

🎉 Source Amazon Ads: improve docs for beta #12541

Conversation

grubberr commented May 3, 2022 • edited Loading

What

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

codecov bot commented May 3, 2022 • edited Loading

Codecov Report

grubberr commented May 4, 2022 • edited by github-actions bot Loading

grubberr commented May 4, 2022 • edited by github-actions bot Loading

CLAassistant commented May 5, 2022 • edited Loading

grubberr commented May 8, 2022 • edited by github-actions bot Loading

grubberr commented May 8, 2022 • edited by github-actions bot Loading

grubberr commented May 8, 2022 • edited by github-actions bot Loading

grubberr commented May 3, 2022 •

edited

Loading

codecov bot commented May 3, 2022 •

edited

Loading

grubberr commented May 4, 2022 •

edited by github-actions bot

Loading

grubberr commented May 4, 2022 •

edited by github-actions bot

Loading

CLAassistant commented May 5, 2022 •

edited

Loading

grubberr commented May 8, 2022 •

edited by github-actions bot

Loading

grubberr commented May 8, 2022 •

edited by github-actions bot

Loading

grubberr commented May 8, 2022 •

edited by github-actions bot

Loading