🎉Source Postgres (CDC) - add support of tsquery type #13083

yurii-bidiuk · 2022-05-23T10:51:36Z

What

Fixes #7911

How

Describe the solution

🚨 User Impact 🚨

There is no user impact

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

yurii-bidiuk · 2022-05-23T12:57:09Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2371415274
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2371415274
No Python unittests run

alexandertsukanov

LGTM

alexandr-shegeda

LGTM. we can proceed with publishing and merging without airbyte review

yurii-bidiuk · 2022-05-25T13:01:50Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2384596514
❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres

yurii-bidiuk · 2022-05-26T10:43:24Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2390177938
❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres

yurii-bidiuk · 2022-05-26T13:17:40Z

/publish connector=connectors/source-postgres auto-bump-version=false

❌ Failed to publish connectors/source-postgres

yurii-bidiuk · 2022-05-26T13:24:28Z

/publish connector=connectors/source-postgres auto-bump-version=false

❌ Failed to publish connectors/source-postgres

yurii-bidiuk · 2022-05-26T13:31:36Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2390942054
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2390942054
No Python unittests run

yurii-bidiuk · 2022-05-26T13:44:45Z

/publish connector=connectors/source-postgres

❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres

grishick · 2022-05-26T15:30:30Z

Looking at the log, I think publish task is failing because of a timeout again. It failed after 4 hours, which corresponds to 240 minute timeout.

grishick · 2022-05-27T21:53:43Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2398935384
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2398935384
No Python unittests run

Build Passed

Test summary info:

All Passed

grishick · 2022-05-27T23:47:55Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2399287619
❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres

grishick · 2022-05-28T06:44:49Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2400237250
❌ Failed to publish connectors/source-postgres
❌ Couldn't auto-bump version for connectors/source-postgres

grishick · 2022-05-28T23:20:06Z

/publish connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2402533991
🚀 Successfully published connectors/source-postgres
🚀 Auto-bumped version for connectors/source-postgres
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/2402533991

* cdc - add support of tsquery type * rebase on master * Add changes made by the build * Update version in Dockerfile * auto-bump connector version Co-authored-by: grishick <greg@airbyte.io> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

yurii-bidiuk requested review from alexandr-shegeda and alexandertsukanov May 23, 2022 10:51

github-actions bot added the area/connectors Connector related issues label May 23, 2022

alexandertsukanov approved these changes May 24, 2022

View reviewed changes

alexandr-shegeda approved these changes May 24, 2022

View reviewed changes

grishick approved these changes May 24, 2022

View reviewed changes

github-actions bot added the area/documentation Improvements or additions to documentation label May 25, 2022

yurii-bidiuk temporarily deployed to more-secrets May 25, 2022 13:03 Inactive

alexandr-shegeda marked this pull request as ready for review May 26, 2022 13:30

yurii-bidiuk force-pushed the bidiuk/7911-src-postgres-cdc-add-tsquery branch from 6b1f091 to 844cac9 Compare May 26, 2022 13:44

yurii-bidiuk temporarily deployed to more-secrets May 26, 2022 13:46 Inactive

grishick force-pushed the bidiuk/7911-src-postgres-cdc-add-tsquery branch from 844cac9 to 79ce2ac Compare May 27, 2022 21:24

yurii-bidiuk requested a review from a team as a code owner May 27, 2022 23:24

grishick removed the request for review from a team May 27, 2022 23:24

yurii-bidiuk and others added 4 commits May 28, 2022 00:11

cdc - add support of tsquery type

5d1e8b7

rebase on master

4ed0dfa

Add changes made by the build

2253eb3

Update version in Dockerfile

952c8c0

grishick force-pushed the bidiuk/7911-src-postgres-cdc-add-tsquery branch from 262b439 to 952c8c0 Compare May 28, 2022 07:12

auto-bump connector version

186f22d

octavia-squidington-iii temporarily deployed to more-secrets May 29, 2022 01:03 Inactive

grishick merged commit 16de42f into master May 29, 2022

grishick deleted the bidiuk/7911-src-postgres-cdc-add-tsquery branch May 29, 2022 05:04

octavia-squidington-iii mentioned this pull request May 31, 2022

Bump Airbyte version from 0.39.5-alpha to 0.39.6-alpha #13350

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉Source Postgres (CDC) - add support of tsquery type #13083

🎉Source Postgres (CDC) - add support of tsquery type #13083

yurii-bidiuk commented May 23, 2022

yurii-bidiuk commented May 23, 2022 •

edited by github-actions bot

Loading

alexandertsukanov left a comment

alexandr-shegeda left a comment

yurii-bidiuk commented May 25, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

grishick commented May 26, 2022

grishick commented May 27, 2022 •

edited by github-actions bot

Loading

grishick commented May 27, 2022 •

edited by github-actions bot

Loading

grishick commented May 28, 2022 •

edited by github-actions bot

Loading

grishick commented May 28, 2022 •

edited by github-actions bot

Loading

🎉Source Postgres (CDC) - add support of tsquery type #13083

🎉Source Postgres (CDC) - add support of tsquery type #13083

Conversation

yurii-bidiuk commented May 23, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

yurii-bidiuk commented May 23, 2022 • edited by github-actions bot Loading

alexandertsukanov left a comment

Choose a reason for hiding this comment

alexandr-shegeda left a comment

Choose a reason for hiding this comment

yurii-bidiuk commented May 25, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented May 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented May 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented May 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented May 26, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented May 26, 2022 • edited by github-actions bot Loading

grishick commented May 26, 2022

grishick commented May 27, 2022 • edited by github-actions bot Loading

Build Passed

grishick commented May 27, 2022 • edited by github-actions bot Loading

grishick commented May 28, 2022 • edited by github-actions bot Loading

grishick commented May 28, 2022 • edited by github-actions bot Loading

yurii-bidiuk commented May 23, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 25, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

yurii-bidiuk commented May 26, 2022 •

edited by github-actions bot

Loading

grishick commented May 27, 2022 •

edited by github-actions bot

Loading

grishick commented May 27, 2022 •

edited by github-actions bot

Loading

grishick commented May 28, 2022 •

edited by github-actions bot

Loading

grishick commented May 28, 2022 •

edited by github-actions bot

Loading