Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Source Amplitude: Fixed JSON Validator date-time validation #13373

Merged
merged 8 commits into from
Jun 3, 2022
+91 −32
Merged

🐛 Source Amplitude: Fixed JSON Validator date-time validation #13373

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
de3603b
fixed
bazarnov Jun 1, 2022
1498faa
updated readme
bazarnov Jun 1, 2022
33022df
updated changelog
bazarnov Jun 1, 2022
eb90e20
reverted schema change
bazarnov Jun 2, 2022
4c69d04
Merge remote-tracking branch 'origin/master' into bazarnov/13075-sour…
bazarnov Jun 2, 2022
aedcfed
fixed
bazarnov Jun 2, 2022
5a0ce03
updated after review
bazarnov Jun 3, 2022
98f3d2d
auto-bump connector version
octavia-squidington-iii Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amplitude/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.7
LABEL io.airbyte.version=0.1.8
LABEL io.airbyte.name=airbyte/source-amplitude
3 changes: 2 additions & 1 deletion airbyte-integrations/connectors/source-amplitude/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ Customize `acceptance-test-config.yml` file to configure tests. See [Source Acce
If your connector requires to create or destroy resources for use during acceptance tests create fixtures for it and place them inside integration_tests/acceptance.py.
To run your integration tests with acceptance tests, from the connector root, run
```
python -m pytest integration_tests -p integration_tests.acceptance
docker build . --no-cache -t airbyte/source-amplitude:dev \
&& python -m pytest -p source_acceptance_test.plugin
```
To run your integration tests with docker

Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amplitude/source_amplitude/schemas/annotations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"properties": {
"date": {
"type": ["null", "string"],
"format": "date-time"
"format": "date"
},
"details": {
"type": ["null", "string"]
Expand Down
21 changes: 7 additions & 14 deletions airbyte-integrations/connectors/source-amplitude/source_amplitude/schemas/events.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"type": "object",
"properties": {
"server_received_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
},
"app": {
"type": ["null", "integer"]
Expand All @@ -25,8 +24,7 @@
"type": ["null", "string"]
},
"event_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
},
"platform": {
"type": ["null", "string"]
Expand All @@ -38,12 +36,10 @@
"type": ["null", "integer"]
},
"processed_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
},
"user_creation_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
},
"version_name": {
"type": ["null", "string"]
Expand All @@ -64,8 +60,7 @@
"type": ["null", "object"]
},
"client_upload_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
},
"$insert_id": {
"type": ["null", "string"]
Expand All @@ -92,8 +87,7 @@
"type": ["null", "number"]
},
"server_upload_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
},
"event_id": {
"type": ["null", "integer"]
Expand Down Expand Up @@ -153,8 +147,7 @@
"type": ["null", "string"]
},
"client_event_time": {
"type": ["null", "string"],
"format": "date-time"
"type": ["null", "string"]
}
}
}
3 changes: 2 additions & 1 deletion docs/integrations/sources/amplitude.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ The Amplitude connector should gracefully handle Amplitude API limitations under

| Version | Date | Pull Request | Subject |
|:--------| :--------- | :----------------------------------------------------- | :------ |
| 0.1.6 | 2022-05-21 | [13074](https://github.com/airbytehq/airbyte/pull/13074) | Removed time offset for `Events` stream, which caused a lot of duplicated records |
| 0.1.8 | 2022-06-01 | [13373](https://github.com/airbytehq/airbyte/pull/13373) | Fixed the issue when JSON Validator produces erros on `date-time` check |
| 0.1.7 | 2022-05-21 | [13074](https://github.com/airbytehq/airbyte/pull/13074) | Removed time offset for `Events` stream, which caused a lot of duplicated records |
| 0.1.6 | 2022-04-30 | [12500](https://github.com/airbytehq/airbyte/pull/12500) | Improve input configuration copy |
| 0.1.5 | 2022-04-28 | [12430](https://github.com/airbytehq/airbyte/pull/12430) | Added HTTP error descriptions and fixed `Events` stream fail caused by `404` HTTP Error |
| 0.1.4 | 2021-12-23 | [8434](https://github.com/airbytehq/airbyte/pull/8434) | Update fields in source-connectors specifications |
Expand Down