Bmoric/fix test bad catch

[benmoriceau]

What

Remove the static import.

Fix a test which was not testing what it was claiming to test.

[Dharminder315]

Internet connection

[jrhizor]

I'm not sure removing static imports for when and assertThat are useful. They're super common to statically import, and I don't think Assertions.assertThat(x).isEqualTo(y) is easier to read. I don't feel too strongly either way on this though, so 🤷

The exception handling fluent interface (and the improved test cases) is a big improvement though.

[benmoriceau]

I'm not sure removing static imports for when and assertThat are useful. They're super common to statically import, and I don't think Assertions.assertThat(x).isEqualTo(y) is easier to read. I don't feel too strongly either way on this though, so 🤷

The exception handling fluent interface (and the improved test cases) is a big improvement though.

For the static import, I like to remove them for on main reason: autocompletion. I like to be able to type the root class name and see what is available. I have removed it for this review.

I agree that Assertions.assertThat(x).isEqualTo(y) doesn't bring much but overall AssertJ has much better wrapper that Junit5 to make your test as easy to understand as possible. For example you can test list like that:

assertThat(list).hasSize(2)
        .containsExactlyInAnyOrder("blabla")
        .isSubsetOf(Lists.newArrayList("1", "2"));

They provide those nice wrapper for many type of the java standard lib. I would prefer to use it everywhere we can even if for some case it might not bring much for some assertion.