Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fields in destination-connectors specifications: gcs, jdbc, kafka, keen, kinesis, kvdb, local-json, mariadb-columnstore, mongodb #8809

Merged
merged 8 commits into from
Dec 30, 2021

Conversation

igrankova
Copy link
Contributor

@igrankova igrankova commented Dec 15, 2021

What

Add title and description properties to each field in destination-connectors specifications:
destination-gcs
destination-jdbc
destination-kafka
destination-keen
destination-kinesis
destination-kvdb
destination-local-json
destination-mariadb-columnstore
destination-mongodb

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

@igrankova igrankova added area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Dec 15, 2021
@igrankova igrankova self-assigned this Dec 15, 2021
@github-actions github-actions bot removed the area/documentation Improvements or additions to documentation label Dec 15, 2021
@igrankova igrankova temporarily deployed to more-secrets December 15, 2021 12:04 Inactive
@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1582607556
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1582607556
🐛

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-jdbc

🕑 connectors/destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/1582608890
✅ connectors/destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/1582608890
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-kafka

🕑 connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1582609223
✅ connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1582609223
No Python unittests run

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-keen

🕑 connectors/destination-keen https://github.com/airbytehq/airbyte/actions/runs/1582609867
❌ connectors/destination-keen https://github.com/airbytehq/airbyte/actions/runs/1582609867
🐛

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-kinesis

🕑 connectors/destination-kinesis https://github.com/airbytehq/airbyte/actions/runs/1582611019
✅ connectors/destination-kinesis https://github.com/airbytehq/airbyte/actions/runs/1582611019
No Python unittests run

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-kvdb

🕑 connectors/destination-kvdb https://github.com/airbytehq/airbyte/actions/runs/1582611309
❌ connectors/destination-kvdb https://github.com/airbytehq/airbyte/actions/runs/1582611309
🐛

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-local-json

🕑 connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/1582611725
✅ connectors/destination-local-json https://github.com/airbytehq/airbyte/actions/runs/1582611725
No Python unittests run

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-mariadb-columnstore

🕑 connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/1582612593
✅ connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/1582612593
No Python unittests run

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-mongodb

🕑 connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/1582613321
✅ connectors/destination-mongodb https://github.com/airbytehq/airbyte/actions/runs/1582613321
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:06 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:07 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 15, 2021 12:07 Inactive
@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1583357309
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1583357309
🐛

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-jdbc

🕑 connectors/destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/1583357753
✅ connectors/destination-jdbc https://github.com/airbytehq/airbyte/actions/runs/1583357753
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                              Stmts   Miss  Cover
	 -------------------------------------------------------------------------------------
	 main_dev_transform_catalog.py                                         3      3     0%
	 main_dev_transform_config.py                                          3      3     0%
	 normalization/__init__.py                                             4      0   100%
	 normalization/destination_type.py                                    13      0   100%
	 normalization/transform_catalog/__init__.py                           2      0   100%
	 normalization/transform_catalog/catalog_processor.py                143     77    46%
	 normalization/transform_catalog/destination_name_transformer.py     124      6    95%
	 normalization/transform_catalog/reserved_keywords.py                 13      0   100%
	 normalization/transform_catalog/stream_processor.py                 494    313    37%
	 normalization/transform_catalog/table_name_registry.py              174     34    80%
	 normalization/transform_catalog/transform.py                         45     26    42%
	 normalization/transform_catalog/utils.py                             33      7    79%
	 normalization/transform_config/__init__.py                            2      0   100%
	 normalization/transform_config/transform.py                         146     32    78%
	 -------------------------------------------------------------------------------------
	 TOTAL                                                              1199    501    58%

@igrankova
Copy link
Contributor Author

igrankova commented Dec 15, 2021

/test connector=connectors/destination-kafka

🕑 connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1583358366
✅ connectors/destination-kafka https://github.com/airbytehq/airbyte/actions/runs/1583358366
No Python unittests run

@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 11:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 11:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 11:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 11:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 11:38 Inactive
@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 11:38 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Dec 30, 2021
@grubberr grubberr temporarily deployed to more-secrets December 30, 2021 12:34 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr grubberr temporarily deployed to more-secrets December 30, 2021 12:37 Inactive
@grubberr
Copy link
Contributor

grubberr commented Dec 30, 2021

/publish connector=connectors/destination-mariadb-columnstore run-tests=false

🕑 connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/1637717065
✅ connectors/destination-mariadb-columnstore https://github.com/airbytehq/airbyte/actions/runs/1637717065

@jrhizor jrhizor temporarily deployed to more-secrets December 30, 2021 14:07 Inactive
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment