Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.google.errorprone:error_prone_annotations from 2.31.0 to 2.32.0 #492

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 11, 2024

Bumps com.google.errorprone:error_prone_annotations from 2.31.0 to 2.32.0.

Release notes

Sourced from com.google.errorprone:error_prone_annotations's releases.

Error Prone 2.32.0

The minimum support JDK version to run Error Prone is now JDK 17 (#3803).

Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will requires using JDK 17 or newer for compilation and setting --release or -source/-target/-bootclasspath.

Full changelog: google/error-prone@v2.31.0...v2.32.0

Commits
  • 0fe0961 Release Error Prone 2.32.0
  • 655bdc4 Update release.yml: remove JDK 11
  • a9ff9b1 Update ci.yml: remove JDK 11
  • 4e0b19c Start using Java > 11 language features in Error Prone tests
  • 4b5ee1e Update ci.yml: always set up JDK 17
  • 494e2c6 Don't perform the inlining if parameter names are stripped.
  • dab4089 Add the name of the method to the diagnostic message for MemberName.
  • 671ac41 Update ci.yml to use javadoc:javadoc
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @wendigo.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [com.google.errorprone:error_prone_annotations](https://github.com/google/error-prone) from 2.31.0 to 2.32.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.31.0...v2.32.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_annotations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependency Dependency updates label Sep 11, 2024
@wendigo
Copy link
Contributor

wendigo commented Sep 11, 2024

@dependabot merge

@dependabot dependabot bot merged commit 0135782 into master Sep 11, 2024
4 checks passed
@dependabot dependabot bot deleted the dependabot/maven/com.google.errorprone-error_prone_annotations-2.32.0 branch September 11, 2024 20:16
@@ -202,7 +202,7 @@
<dep.assertj-core.version>3.26.3</dep.assertj-core.version>
<dep.byte-buddy.version>1.15.1</dep.byte-buddy.version>
<dep.checkstyle.version>10.18.1</dep.checkstyle.version>
<dep.errorprone.version>2.31.0</dep.errorprone.version>
<dep.errorprone.version>2.32.0</dep.errorprone.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version requires JDK 17 and airbase defaults to JDK 8 (<project.build.targetJdk>8</project.build.targetJdk>)
google/error-prone#3803 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus airbase out of the box configuration doesn't work now.
We either revert this update, or change project.build.targetJdk default to be 17 or newer, dropping support for Java 8 and 11 in airbase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target is --release

@wendigo
Copy link
Contributor

wendigo commented Sep 12, 2024

@findepi --release 8 still works but the required JDK is higher. You can target 8 by using JDK 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants