Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from python 3.8-3.10 to 3.10-12 #103

Closed
tlpss opened this issue Jan 2, 2024 · 4 comments · Fixed by #112
Closed

move from python 3.8-3.10 to 3.10-12 #103

tlpss opened this issue Jan 2, 2024 · 4 comments · Fixed by #112
Assignees
Labels
enhancement New feature or request

Comments

@tlpss
Copy link
Contributor

tlpss commented Jan 2, 2024

3.8 will be EOL in oktober, So I would argue we can move to >=3.10. which we can enforce in the python setup.py

would also need to change tests here:

python-version: [3.8, 3.9,'3.10']

@tlpss tlpss added the enhancement New feature or request label Jan 2, 2024
@tlpss
Copy link
Contributor Author

tlpss commented Jan 3, 2024

@Victorlouisdg @adverley anyone has an issue with this proposed change?

@tlpss
Copy link
Contributor Author

tlpss commented Jan 3, 2024

also need to change the conda environment's default python version

@tlpss tlpss self-assigned this Jan 3, 2024
@Victorlouisdg
Copy link
Contributor

Sounds good to me, however some packages like ur_rtde only have prebuilt wheels up to 3.11 I believe, making it difficult to install on 3.12.

We should probably also update our types too then, because 3.10 allow tuple instead of Tuple etc.

@adverley
Copy link
Contributor

adverley commented Jan 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants