Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Data should not depend on system naming of interfaces #285

Closed
jingvar opened this issue Jun 25, 2020 · 6 comments
Closed

Network Data should not depend on system naming of interfaces #285

jingvar opened this issue Jun 25, 2020 · 6 comments
Assignees
@jingvar
Labels
enhancement New feature or request
Milestone
v2.0

Comments

@jingvar
Copy link
Contributor

jingvar commented Jun 25, 2020

Problem description (if applicable)
We have hardcoded naming of interfaces.
manifests/site/test-site/shared/baremetalhost/node02/networkData
" ...

  • id: enp0s3
    name: enp0s3"
    ...
    "
    This works for Debian, but some distributions may use different naming.
    If we try to use real bare metal for gating tests, we must take care of the names for the environment.
    My expectation is an user just have to change redfish urls and credentials.

Proposed change
Update networkdata for gate test with using MAC for interface naming.
VM creation script should use MAC from networkdata.

Potential impacts
None
@jingvar jingvar added enhancement New feature or request triage Needs evaluation by project members labels Jun 25, 2020
@jingvar
Copy link
Contributor Author

jingvar commented Jun 26, 2020

Please assign to me

@jezogwza
Copy link
Contributor

jezogwza commented Jul 1, 2020

I believe this falls also under the umbrella of the Host Profile diffused into the document set. Either this MAC approach or been able to declarative define the names for interfaces for the machines as part of the declarative that the HostTemplate Generator uses,

@jezogwza jezogwza added design needed New Design or Redesign required and removed triage Needs evaluation by project members labels Jul 1, 2020
@jezogwza jezogwza added this to the v2.0 milestone Jul 1, 2020
@drewwalters96
Copy link
Contributor

@jingvar assigned!

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Jul 7, 2020
@airshipbot
Copy link

airshipbot commented Jul 7, 2020 •
edited
Loading

Related Change #739132

Subject: Add usage MAC for Ephemeral VM deploy
Link: https://review.opendev.org/739132
Status: MERGED
Owner: Nikolay Fedorov (nfedorov@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+2 Stas Egorov
Verified
+2 Zuul
Workflow
+1 Stas Egorov

Last Updated: 2020-08-05 11:30:09 CDT

@eak13 eak13 removed the design needed New Design or Redesign required label Aug 5, 2020
airshipbot pushed a commit that referenced this issue Aug 5, 2020
@jingvar
Add usage MAC for Ephemeral VM deploy
bd6f2f8 
We should use interface naming independent on OS, type, speed, slot etc.
This CR takes an approach that is already used for the target node.
To define VMs, their script uses MAC addresses from manifests.

Relates-To: #285

Change-Id: Iafffd23bc584d2daf3fed5ee301491f447498193
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/739132 was merged. This issue may be ready to close.

@drewwalters96
Copy link
Contributor

@airshipbot indeed it has. Thanks!

@eak13 eak13 removed the ready for review Change related to the issue is ready for review label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jingvar jingvar

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
5 participants
@eak13 @jezogwza @drewwalters96 @jingvar @airshipbot