Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement container build for airshipctl document plugins #341

Closed
dukov opened this issue Sep 1, 2020 · 7 comments
Closed

Implement container build for airshipctl document plugins #341

dukov opened this issue Sep 1, 2020 · 7 comments
Assignees
@sirajyasin
Labels
design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items ready for review Change related to the issue is ready for review
Milestone
v2.0

Comments

@dukov
Copy link
Member

dukov commented Sep 1, 2020

Proposed change

  • Introduce Dockerfile for plugin containers
  • Extend Makefile with container build procedure

Potential impacts
N/A
@dukov dukov added enhancement New feature or request triage Needs evaluation by project members labels Sep 1, 2020
@dukov
Copy link
Member Author

dukov commented Sep 1, 2020

Relates to #322

@sirajyasin
Copy link
Contributor

@dukov , I have pushed a PS(WIP) in airship/images repo to create docker image for ktp-functions plugins ( templater ). The work is not complete. But wanted to know if i am moving in correct direction.

https://review.opendev.org/#/c/749406/

Please suggest if we should have those plugin code in airshipctl repo or images repo. I thought the plugin code is very independent of airshipctl, so tried to keep in images repo. Please suggest.

@jezogwza jezogwza added this to the v2.0 milestone Sep 2, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Sep 2, 2020
@dukov dukov added the design needed New Design or Redesign required label Sep 3, 2020
@jezogwza jezogwza added the priority/medium Default priority for items label Oct 7, 2020
@airshipbot
Copy link

airshipbot commented Oct 9, 2020 •
edited
Loading

Related Change #757147

Subject: Introduce Replacement Transformer plugin container
Link: https://review.opendev.org/757147
Status: MERGED
Owner: Dmitry Ukov (dukov@mirantis.com)

Approvals

Code-Review
+2 Matt McEuen
+2 Stas Egorov
+1 srinivasa muly
+1 Bijaya Sharma
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-10-19 14:15:05 CDT

@airshipbot airshipbot added ready for review Change related to the issue is ready for review wip Work in progress and removed ready for review Change related to the issue is ready for review wip Work in progress labels Oct 9, 2020
@airshipbot airshipbot added wip Work in progress and removed ready for review Change related to the issue is ready for review labels Oct 15, 2020
@airshipbot
Copy link

airshipbot commented Oct 15, 2020 •
edited
Loading

Related Change #758452

Subject: Container build for Templater plugin
Link: https://review.opendev.org/758452
Status: MERGED
Owner: Sirajudeen (sirajudeen.yasin@gmail.com)

Approvals

Code-Review
+2 Dmitry Ukov
+2 Stas Egorov
Verified
+2 Zuul
Workflow
+1 Stas Egorov

Last Updated: 2020-10-22 11:00:03 CDT

@airshipbot airshipbot added ready for review Change related to the issue is ready for review wip Work in progress and removed wip Work in progress ready for review Change related to the issue is ready for review labels Oct 15, 2020
@airshipbot airshipbot added wip Work in progress ready for review Change related to the issue is ready for review and removed wip Work in progress ready for review Change related to the issue is ready for review labels Oct 15, 2020
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/757147 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Oct 19, 2020
@dukov
Introduce Replacement Transformer plugin container
d783d71 
Relates-To: #341
Change-Id: I65a5b8cf3bcf94321fc02f240b1d8075bca45c0c
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/758452 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Oct 22, 2020
@sirajyasin
Container build for Templater plugin
909d427 
Change-Id: I53384561517070a0dca901ee263a5c1a1e55dffa
Relates-To: #341
@eak13
Copy link

eak13 commented Oct 23, 2020

Closing with code merge per @sirajyasin

@eak13 eak13 closed this as completed Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirajyasin sirajyasin

Labels
design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items ready for review Change related to the issue is ready for review
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
5 participants
@dukov @eak13 @jezogwza @sirajyasin @airshipbot