Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate Phase Operations to Kubernetes Clusters via Manifests #342

Closed
lb4368 opened this issue Sep 1, 2020 · 19 comments
Closed

Associate Phase Operations to Kubernetes Clusters via Manifests #342

lb4368 opened this issue Sep 1, 2020 · 19 comments
Assignees
@teoyaomiqui
Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Milestone
betav1

Comments

@lb4368
Copy link

lb4368 commented Sep 1, 2020

Problem description
As an operator I want to be able to associate each airshipctl phase to the kubernetes cluster and associated kubeconfig on which the phase will be performed in a declarative manner so that phases can be managed across multiple clusters including worker clusters.

Proposed change
Provide a mechanism to associate a phase to a specific kubernetes cluster managed in the site. A phase run via airshipctl then should be able to extract the appropriate kubeconfig file for the cluster either by reading it from the site document bundle or by extracting it from a parent management cluster associated to the specified cluster.

Potential impacts
This issue is related to #324 which specifies support for workload clusters.
@lb4368 lb4368 added enhancement New feature or request triage Needs evaluation by project members labels Sep 1, 2020
@lb4368
Copy link
Author

lb4368 commented Sep 1, 2020

This was discussed on 8/27/2020 and 9/1/2020 design calls.

See proposed implementation here: https://review.opendev.org/#/c/748029/
Related diagram: https://go.gliffy.com/go/publish/13350794

@eak13
Copy link

eak13 commented Sep 1, 2020

To determine which kubeconfig to use the following logic will be applied:

  • File system flag = provide own kubeconfig flag just passed to the executor as is. Executor will look for the context set by cluster name
  • With clusterctl move need 2 clusters/kubeconfig. Use the same kubeconfig with the cluster name for the phase apply, take the cluster map get the parent of the kubeconfig & use that to set the context of from & to
  • Workload cluster - take the cluster name, check for dynamic, if true, check parent cluster, get parent kubeconfig & use to get the cluster kubeconfig
  • If dynamic kubeconfig = false, use the kubeconfig as is from the document set
  • One cluster map with the different contexts based on cluster name

@jezogwza jezogwza added this to the betav1 milestone Sep 2, 2020
@jezogwza jezogwza removed the triage Needs evaluation by project members label Sep 2, 2020
@airshipbot
Copy link

airshipbot commented Sep 9, 2020 •
edited
Loading

Related Change #750556

Subject: Implement helper interface
Link: https://review.opendev.org/750556
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+1 Ruslan Aliev
+2 Ian Howell
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-09-11 12:00:07 CDT

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Sep 9, 2020
@airshipbot
Copy link

airshipbot commented Sep 9, 2020 •
edited
Loading

Related Change #750563

Subject: Switch phase commands to use refactored command objects
Link: https://review.opendev.org/750563
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Matt McEuen
+1 Bijaya Sharma
+1 Ruslan Aliev
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-09-14 15:15:05 CDT

@airshipbot
Copy link

airshipbot commented Sep 9, 2020 •
edited
Loading

Related Change #750560

Subject: Use Helper in clusterctl and kube apply executors
Link: https://review.opendev.org/750560
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Matt McEuen
+2 Stas Egorov
+1 Ruslan Aliev
Verified
+2 Zuul
Workflow
+1 Kostyantyn Kalynovskyi

Last Updated: 2020-09-14 14:15:05 CDT

@airshipbot
Copy link

airshipbot commented Sep 9, 2020 •
edited
Loading

Related Change #750557

Subject: Implement phase and phase.Client interface
Link: https://review.opendev.org/750557
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Drew Walters
+2 Stas Egorov
Verified
+2 Zuul
Workflow
+1 Stas Egorov

Last Updated: 2020-09-11 21:00:04 CDT

@airshipbot
Copy link

airshipbot commented Sep 9, 2020 •
edited
Loading

Related Change #750567

Subject: Cleanup phase package
Link: https://review.opendev.org/750567
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+1 Vladimir Kozhukalov
+2 Ian Howell
+2 Matt McEuen
Verified
+2 Zuul
Workflow
+1 Matt McEuen

Last Updated: 2020-09-15 15:45:07 CDT

@airshipbot
Copy link

A [Related Change](https://review.opendev.org/750556 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 11, 2020
@teoyaomiqui
Implement helper interface
76b1ffd 
Change-Id: If65d7d8cd3fa082facc077753bb06275da2a6643
Relates-To: #342
airshipbot pushed a commit that referenced this issue Sep 12, 2020
@teoyaomiqui
Implement phase and phase.Client interface
d79c71e 
Relates-To: #342

Change-Id: I8882204c0e9eae05fca30c093fcd3bad58e308e1
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/750557 was merged. This issue may be ready to close.

@airshipbot
Copy link

A [Related Change](https://review.opendev.org/750560 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 14, 2020
@teoyaomiqui
Use Helper in clusterctl and kube apply executors
410f9c4 
Relates-To: #342

Change-Id: I6f3f9b5aac3877f5738f0ec077c65bcf5acfc54d
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/750563 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 14, 2020
@teoyaomiqui
Switch phase commands to use refactored command objects
5c67094 
Change-Id: I1f9f1620d6e0d3ac836e0189f403b7f794818d53
Relates-To: #342
@airshipbot
Copy link

airshipbot commented Sep 14, 2020 •
edited
Loading

Related Change #751904

Subject: Use cluster name as context in executors
Link: https://review.opendev.org/751904
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Stas Egorov
+2 Drew Walters
Verified
+2 Zuul
Workflow
+1 Drew Walters

Last Updated: 2020-09-15 14:45:05 CDT

@airshipbot
Copy link

airshipbot commented Sep 14, 2020 •
edited
Loading

Related Change #751909

Subject: Implement clusterctl move executor
Link: https://review.opendev.org/751909
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+2 Ian Howell
+1 Vladimir Kozhukalov
+2 Dmitry Ukov
Verified
+2 Zuul
Workflow
+1 Dmitry Ukov

Last Updated: 2020-09-15 12:45:04 CDT

@airshipbot
Copy link

A [Related Change](https://review.opendev.org/751909 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 15, 2020
@teoyaomiqui
Implement clusterctl move executor
6114d58 
Change-Id: Ibb3aea6ead51409b9cbd69cc02e685d3fce186a4
Relates-To: #342
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/751904 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 15, 2020
@teoyaomiqui
Use cluster name as context in executors
2851301 
Change-Id: I4fcf524dd2ff466290b80df7d966f90aa0409471
Relates-To: #342
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/750567 was merged. This issue may be ready to close.

airshipbot pushed a commit that referenced this issue Sep 15, 2020
@teoyaomiqui
Cleanup phase package
b63c9e3 
Change-Id: Ib849da5faa2f69f058bd9df814b55e117ecefb8a
Relates-To: #342
@airshipbot airshipbot added the wip Work in progress label Sep 15, 2020
@airshipbot
Copy link

airshipbot commented Sep 15, 2020 •
edited
Loading

Related Change #749419

Subject: Switch to using phase documents
Link: https://review.opendev.org/749419
Status: MERGED
Owner: Kostyantyn Kalynovskyi (kkalynovskyi@mirantis.com)

Approvals

Code-Review
+1 Sean Eagan
+1 Ruslan Aliev
+2 Stas Egorov
+1 Bijaya Sharma
+2 Ian Howell
Verified
+2 Zuul
Workflow
+1 Ian Howell

Last Updated: 2020-09-16 16:15:03 CDT

@airshipbot airshipbot added ready for review Change related to the issue is ready for review and removed ready for review Change related to the issue is ready for review wip Work in progress labels Sep 15, 2020
airshipbot pushed a commit that referenced this issue Sep 16, 2020
@teoyaomiqui
Switch to using phase documents
f4baf5a 
This commit allows to stop using phases with hardcoded paths to
kustomize entrypoints. Instead we use phase documents defined
in bundles. Phase document has a reference to executor such as
kubernetes apply and clusterctl init. More executors are being
developed

Relates-To: #342

Change-Id: I8babd9d0379763773c443e263373e9816f9dbd39
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/749419 was merged. This issue may be ready to close.

@jezogwza
Copy link
Contributor

jezogwza commented Sep 30, 2020 •
edited
Loading

All the patchsets associated with this have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teoyaomiqui teoyaomiqui

Labels
enhancement New feature or request ready for review Change related to the issue is ready for review
Projects
None yet
Milestone
betav1
Development

No branches or pull requests
5 participants
@lb4368 @eak13 @jezogwza @teoyaomiqui @airshipbot