Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running gate behind the proxy #355

Closed
realsystem opened this issue Sep 23, 2020 · 4 comments
Closed

Running gate behind the proxy #355

realsystem opened this issue Sep 23, 2020 · 4 comments
Assignees
@realsystem
Labels
design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items ready for review Change related to the issue is ready for review
Milestone
v2.0

Comments

@realsystem
Copy link

As an operator, I would like to deploy clusters behind the corporate proxy. Right now not all places covered by PROXY environment variables and need some manual intervention to the scripts/manifests. Better to automate this.

Proposal: get the PROXY from env vars and drop it where it is needed in the code(scripts/manifests).
@realsystem realsystem added enhancement New feature or request triage Needs evaluation by project members labels Sep 23, 2020
@realsystem realsystem self-assigned this Sep 23, 2020
@realsystem
Copy link
Author

The first draft is to use PROXY from env vars in the ironic pod definition via configMap generator: https://review.opendev.org/752625

The second part is for ephemeral secret: https://review.opendev.org/753514 and https://review.opendev.org/753515

But the same things can be done by replacement transformer in kustomize. Working on it.

@airshipbot
Copy link

airshipbot commented Sep 24, 2020 •
edited
Loading

Related Change #753933

Subject: Use proxy settings from env vars
Link: https://review.opendev.org/753933
Status: MERGED
Owner: Stas Egorov (segorov@mirantis.com)

Approvals

Code-Review
+2 Dmitry Ukov
+2 Drew Walters
Verified
+2 Zuul
Workflow
+1 Drew Walters

Last Updated: 2020-10-07 15:00:03 CDT

@airshipbot airshipbot added the ready for review Change related to the issue is ready for review label Sep 24, 2020
@jezogwza jezogwza added this to the v2.0 milestone Sep 30, 2020
@jezogwza jezogwza added design needed New Design or Redesign required priority/medium Default priority for items and removed triage Needs evaluation by project members labels Sep 30, 2020
airshipbot pushed a commit that referenced this issue Oct 7, 2020
Use proxy settings from env vars
bccfe4b 
For the labs behind the corporate proxy we need to define proxy settings as env vars.
Inside Ironic pod there is init-bootstrap container which is using curl with external
URLs. This change introduces the env vars for proxy in the ConfigMap mounted to all
Ironic containers in the pod. Also Ephemeral Secret now has an option to use proxy.

Relates-To: #355

Change-Id: I4f1c61c8381d57e4ad8adc063434468fdfa0e959
@airshipbot
Copy link

A [Related Change](https://review.opendev.org/753933 was merged. This issue may be ready to close.

@realsystem
Copy link
Author

https://review.opendev.org/755085

https://review.opendev.org/756601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realsystem realsystem

Labels
design needed New Design or Redesign required enhancement New feature or request priority/medium Default priority for items ready for review Change related to the issue is ready for review
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
3 participants
@realsystem @jezogwza @airshipbot