Set containerd as default CRI & systemd as the default cgroup driver

[eak13]

As an Airship user, I want to have containerd as the default container runtime interface & systemd as the cgroup driver, so that we leverage industry standard drivers & future proof the platform.

Airship 2.0 currently uses docker as the default CRI (explicitly defined) & cgroupfs as the default cgroup driver (assumed default).

Docker being deprecated as k8s CRI v1.20
https://kubernetes.io/blog/2020/12/02/dont-panic-kubernetes-and-docker/

Proposed change
Set containerd as the default CRI

Information on container runtimes & cgroup drivers:
https://kubernetes.io/docs/setup/production-environment/container-runtimes/
https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/install-kubeadm/#configure-cgroup-driver-used-by-kubelet-on-control-plane-node

[vs422h]

Could you please assign this issue to me?

[michaelfix]

@vs422h (Vladimir) - is there an update?

[vs422h]

PS is on the review, but it seems like this issue could be closed as an outdated. All CRI deployments are implemented in the image-bulder module, and this piece of code looks duplicated and could be removed.
For the reference: https://github.com/airshipit/images/tree/master/image-builder
I'd like to request a short technical discussion.

[michaelfix]

@ak3216 , @jezogwza , is what Vladimir is doing(done) duplicate, or obsolete?

[eak13]

@vs422h (@mf4716 & @jezogwza), I was verifying that CRI & CGroup driver are being set in image builder & it looks like the CGroup driver is being set to systemd here: https://github.com/airshipit/images/blob/master/image-builder/assets/playbooks/roles/osconfig/tasks/crio.yaml but CRI is not being set by Image Builder.

I double checked with Craig & he reminded me that in earlier versions of k8s it was possible to set this via command-line arguments in which case it would have been possible to do it with image-builder. However that functionality was removed and now must be configured in the Kubernetes config along with all the other config params. So it sounds like we'll still need to set the CRI via airshipctl, but I can update this issue to make the CGroup driver just a verify given it should be handled by Image Builder.

[michaelfix]

@vs422h - Vladimir, are we closer to finishing, or confirming if this is dup/or moved to another issue #?

[lb4368]

Related PS: https://review.opendev.org/c/airship/airshipctl/+/775945

[airshipbot]

Related Change #775945

Subject: Update default CRI and cgroup driver
Link: https://review.opendev.org/c/airship/airshipctl/+/775945
Status: ABANDONED
Owner: Vladimir Sigunov (vladimir.sigunov@att.com)

Approvals

Code-Review
! None
Verified
-1 ATT Airship2.0 CI
+1 Zuul
Workflow
! None

Last Updated: 2021-04-20 16:39:43 CDT

[airshipbot]

Related Change #787290

Subject: Update default CRI and cgroup driver
Link: https://review.opendev.org/c/airship/airshipctl/+/787290
Status: MERGED
Owner: Vladimir Sigunov (vladimir.sigunov@att.com)

Approvals

Code-Review
+2 Kostyantyn Kalynovskyi
+1 Alexey
+2 Ruslan Aliev
Verified
-1 ATT Airship2.0 CI
+2 Zuul
Workflow
+1 Ruslan Aliev

Last Updated: 2021-05-25 11:59:03 CDT

[vs422h]

The patchset is ready to review: https://review.opendev.org/c/airship/airshipctl/+/787290

[eak13]

Closing per patchset merges.