Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIAP: Utilize document pull command for arbitrary refspecs #623

Closed
ian-howell opened this issue Aug 30, 2021 · 0 comments
Closed

AIAP: Utilize document pull command for arbitrary refspecs #623

ian-howell opened this issue Aug 30, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request priority/medium Default priority for items size m
Milestone

Comments

@ian-howell
Copy link
Contributor

Problem description (if applicable)
We would like to be able to use AIAP with manifests other than the current upstream master gating site. As of cb080a2, We now have the ability to specify an arbitrary refspec for the document pull command. I would like to be able to use that feature in AIAP so that I could test other manifests. This could be done by specifying a refspec as an environment variable passed into AIAP's runner container.

Proposed change
Modify the AIAP runner scripts to insert a new variable (e.g. MANIFESTS_SITE) into the airshipctl config file's repository.fetch.remoteRefSpec field to be used by document pull

@ian-howell ian-howell added enhancement New feature or request triage Needs evaluation by project members size m labels Aug 30, 2021
@ian-howell ian-howell self-assigned this Aug 30, 2021
@jezogwza jezogwza added this to the v2.2 milestone Sep 1, 2021
@jezogwza jezogwza added priority/medium Default priority for items and removed triage Needs evaluation by project members labels Sep 1, 2021
airshipbot pushed a commit that referenced this issue Sep 7, 2021
This causes the 22_test_configs.sh to create an airship config file
which supports the new document pull feature introduced in
https://opendev.org/airship/airshipctl/commit/cb080a20664196e61b0586b7ef7ecdb3a1090c88

Change-Id: I057bd2420f488a9f91ed69d09f73b1336827e7a2

Relates-To: #623
Change-Id: I7bbf052877e4918e168fc4005ea899aa700bae41
@eak13 eak13 modified the milestones: v2.2, v2.1 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/medium Default priority for items size m
Projects
None yet
Development

No branches or pull requests

3 participants