Add tests for conversion from and to ASN.1 Integers for EC signatures

[mschwaig]

This resolves #157 by

• adding tests for ASN.1 tests,

but also

• improves some error messages in the EC implementation and
• moves the conversion functions under test into an internal struct for now.

Moving the conversion logic into theECCurveType like suggested in #156 (comment) might still be a good idea, but I did not do this for now. Feel free to do that.

[Jose-ElRobot]

	1 Message
📖	Any non-trivial changes to code should be reflected in the changelog. Please consider adding a note in the Unreleased section of the CHANGELOG.md.

Generated by 🚫 Danger

[ghost]

Hi @mschwaig, thanks for following up on #156 with an extended test suite and sorry for the delay. I'll give it a thorough review on Wednesday. Expect your changes to be released with a new version of JOSESwift this week. I hope this is ok with you.

[mschwaig]

Hi @mschwaig, thanks for following up on #156 with an extended test suite and sorry for the delay. I'll give it a thorough review on Wednesday. Expect your changes to be released with a new version of JOSESwift this week. I hope this is ok with you.

Sounds good, thanks. 😎

[ghost]

Awesome, thanks a lot @mschwaig! That's exactly what we needed. 👌

I think I spotted one small mistake in the tests. Should be an easy fix, though.

[mschwaig]

Hi Daniel!
You definitely found a bug in the tests and fixed it correctly. I applied your fix, but I cannot re-run the tests locally right now. I'm guessing that's ok, as long as Travis runs them.

[ghost]

Sweet! Thanks, @mschwaig for your contribution, it was nice to work with you. 🎉

We'll release your changes as 1.8.1. I'll ping you here once they're out.

[ghost]

1.8.1 is released and available on CocoaPods. 🎉