Restructure JWE encryption and decryption #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename asymmetric algorithm * Rename symmetric algorithm * Refactor algorithm enums * Sketch out new encryption flow * Refactor encryption flow * Fix reference to old rsa encrypter * Remove dummy keywrap mode * Fix and extendcompression tests * Add key management mode tests * Adapt rsa tests * Add alg check test * Disable space linter rule for now * Adap AES tests * Add license headers to new files * Make sonarqube happy * Do full Sonarqube analysis in pull requests (#201) * Do sonarqube analysis after test * Log fastlane contents * Remove deletion of coverage report * Update sonar config to point to sonarcloud * Trigger analysis * Exclude tests from duplication calculation * Remove loggign * Dry up signing roundtrip tests (#198) * Dry up tests * Use guard in test helper * Format code * Redo mode creation * REname key encryption mode implementations * Final cleanup * Commit something * Revert "Commit something" This reverts commit 91266d4.
* Replicate encryption flow for decryption * Fix tests * Split rsa mode in two types * Replace deprecated decrypter calls in tests * Remove todos
…ESwift into jwe-crypto-restructure
ghost
self-requested a review
ghost
self-assigned this
Generated by 🚫 Danger |
ghost
removed their request for review
ghost
self-requested a review
|
Kudos, SonarCloud Quality Gate passed!
|
ghost
approved these changes
Feb 17, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the already reviewed code of #203 and #132
Only new changes are re-adding the documentation headers to the
EncrypterandDecrypterinitializers: