Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tune API changes #216

Merged
4 commits merged into from
Feb 20, 2020
Merged

Fine tune API changes #216

4 commits merged into from
Feb 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 20, 2020

Provides deprecated API fallbacks for breaking API changes. This should allow us to release the key wrap implementation as non breaking change as part of the 2.x.x major release.

@ghost ghost requested review from a team February 20, 2020 13:48
@ghost ghost self-assigned this Feb 20, 2020
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch that this could be done without breaking changes!

@ghost
Copy link
Author

ghost commented Feb 20, 2020

Nice catch that this could be done without breaking changes!

Thanks for the typealias idea! 😄

@ghost ghost merged commit be9a532 into master Feb 20, 2020
@ghost ghost deleted the hide-api-changes branch February 20, 2020 14:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant