Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize source files into directories #344

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

daniel-moh
Copy link
Member

Moves some files around to improve organization. No code changes.

Basic structure is:

  • Common/ for, as the name says, commonly used types and utilities
  • CryptoPrimitives/ for generic JOSE-independent cryptographic principles
  • JWS/, JWE/, JWK/ for the respective JOSE implementations
JOSESwift/Sources
├── Common
│   ├── ASN1DEREncoding.swift
│   ├── ASN1DERParsing.swift
│   ├── AlgorithmExtensions.swift
│   ├── Algorithms.swift
│   ├── DataConvertible.swift
│   ├── DataExtensions.swift
│   ├── Deserializer.swift
│   ├── JOSEHeader.swift
│   ├── JOSESwiftError.swift
│   ├── Payload.swift
│   └── Serializer.swift
├── CryptoPrimitives
│   ├── AESCBC
│   │   └── AES.swift
│   ├── AESGCM
│   │   └── AESGCM.swift
│   ├── EC
│   │   ├── EC.swift
│   │   └── ECDHKeyAgreement.swift
│   ├── HMAC
│   │   └── HMAC.swift
│   ├── PBES2
│   │   └── PBES2.swift
│   ├── RSA
│   │   └── RSA.swift
│   ├── Randomness
│   │   └── SecureRandom.swift
│   └── SHA
│       └── Thumbprint.swift
├── JWE
│   ├── Compression
│   │   ├── Compressor.swift
│   │   └── DeflateWrapper.swift
│   ├── ContentEncryption
│   │   ├── ContentEncryption.swift
│   │   └── DefaultCrypto
│   │       ├── AESCBC
│   │       │   └── AESCBCEncryption.swift
│   │       └── AESGCM
│   │           └── AESGCMEncryption.swift
│   ├── Decrypter.swift
│   ├── Encrypter.swift
│   ├── JWE.swift
│   ├── JWEHeader.swift
│   └── KeyManagement
│       ├── DefaultCrypto
│       │   ├── AESKW
│       │   │   └── AESKeyWrappingMode.swift
│       │   ├── DirectEncryption
│       │   │   └── DirectEncryptionMode.swift
│       │   ├── EC
│       │   │   └── ECKeyEncryption.swift
│       │   ├── PBES2
│       │   │   └── PBES2KeyEncryptionMode.swift
│       │   └── RSA
│       │       └── RSAKeyEncryptionMode.swift
│       └── KeyManagementMode.swift
├── JWK
│   ├── EC
│   │   ├── DataECPrivateKey.swift
│   │   ├── DataECPublicKey.swift
│   │   ├── ECKeyCodable.swift
│   │   ├── ECKeyPair.swift
│   │   ├── ECKeys.swift
│   │   ├── SecKeyECPrivateKey.swift
│   │   └── SecKeyECPublicKey.swift
│   ├── JWK.swift
│   ├── JWKExtensions.swift
│   ├── JWKParameters.swift
│   ├── JWKSet.swift
│   ├── JWKSetCodable.swift
│   ├── RSA
│   │   ├── DataRSAPublicKey.swift
│   │   ├── RSAKeyCodable.swift
│   │   ├── RSAKeys.swift
│   │   └── SecKeyRSAPublicKey.swift
│   └── Symmetric
│       ├── DataSymmetricKey.swift
│       ├── SymmetricKeyCodable.swift
│       └── SymmetricKeys.swift
└── JWS
    ├── DefaultCrypto
    │   ├── EC
    │   │   ├── ECSigner.swift
    │   │   └── ECVerifier.swift
    │   ├── HMAC
    │   │   ├── HMACSigner.swift
    │   │   └── HMACVerifier.swift
    │   └── RSA
    │       ├── RSASigner.swift
    │       └── RSAVerifier.swift
    ├── JWS.swift
    ├── JWSHeader.swift
    ├── Signer.swift
    └── Verifier.swift

33 directories, 64 files

@daniel-moh daniel-moh requested a review from haeser August 27, 2024 11:29
@daniel-moh daniel-moh self-assigned this Aug 27, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26 New Code Smells (required ≤ 0)
8 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@daniel-moh daniel-moh merged commit 3ed09a1 into master Aug 27, 2024
7 of 8 checks passed
@daniel-moh daniel-moh deleted the directory-reorg branch August 27, 2024 11:50
@daniel-moh
Copy link
Member Author

Sonar issues are valid but out of scope. This PR just moved files around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants