Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAGS as range parameter, fixes #488 fixes #1027 #1418

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

timkpaine
Copy link

@timkpaine timkpaine commented Jul 13, 2024

ref: #488
ref: #1027

Adds a new supported range_spec TAGS which will just list the tags of the repo and run on those.

  • Don't just list and sort the tags, make sure they are reverse-chronologically sorted. Right now they are alphabetically sorted (which isn't even version-sorted, so not great)
    Running for this repo I get: ['v0.6.3', 'v0.6.2', 'v0.6.1', 'v0.6.0', 'v0.4.2', 'v0.4.1', 'v0.3.1', 'v0.3', 'v0.3b1', 'v0.2.2', 'v0.2.2rc1', 'v0.2.1', 'v0.2', 'v0.2rc2', 'v0.1.1', 'v0.1', 'v0.1rc3', 'v0.1rc2', 'v0.1rc1', 'v0.5.1', 'v0.5', 'v0.4', 'initial'], which matches the output of git tag -l --sort=taggerdate and so looks good

Copy link
Member

@HaoZeke HaoZeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor CI related nit.

asv/commands/run.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants