Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI broken because of shellcheck #1120

Closed
ljupcovangelski opened this issue Mar 3, 2021 · 1 comment
Closed

CI broken because of shellcheck #1120

ljupcovangelski opened this issue Mar 3, 2021 · 1 comment
Assignees
@ljupcovangelski
Labels
fix

Comments

@ljupcovangelski
Copy link
Contributor

Shellcheck fails because of the which command

In scripts/bootstrap.sh line 55:
    printf "Vagrant installed in %s\n" "$(which vagrant)"
                                          ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.
In scripts/bootstrap.sh line 120:
    printf "Virtualbox installed in %s \n" "$(which VBoxManage)"
                                              ^---^ SC2230: which is non-standard. Use builtin 'command -v' instead.
@ljupcovangelski ljupcovangelski self-assigned this Mar 3, 2021
ljupcovangelski added a commit that referenced this issue Mar 3, 2021
@ljupcovangelski
[#1120] Fix Shellcheck
50c3c5e
ljupcovangelski added a commit that referenced this issue Mar 3, 2021
@ljupcovangelski
[#1120] Fix Shellcheck (#1121)
ff9fb86
@ljupcovangelski
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljupcovangelski ljupcovangelski

Labels
fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljupcovangelski