[#1306] Fix contact metadata problem #1307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
reviewed
Mar 19, 2021
| @@ -28,7 +29,7 @@ const mapDispatchToProps = dispatch => ({ | |||
| addMessages: (conversationId: string, messages: Message[]) => dispatch(addMessagesAction({conversationId, messages})), | |||
| onChannel: (channel: Channel) => dispatch(setChannelAction(channel)), | |||
| getConversationInfo: (conversationId: string) => dispatch(getConversationInfo(conversationId)), | |||
| onMetadata: (metadataEvent: MetadataEvent) => dispatch(setMetadataAction(metadataEvent)), | |||
| onMetadata: (metadataEvent: MetadataEvent) => dispatch(setMetadataAction(camelcaseKeys(metadataEvent, {deep: true}))), | |||
There was a problem hiding this comment.
This is missing the stop path for user_data that @AudreyKj implemented in other parts where we map metadata. It's needed, because fields on metadata.user_data are set by the user so they don't conform to our casing
| @@ -209,6 +209,10 @@ function allReducer( | |||
| // Ensure that there is always a display name present | |||
| ...pick(state.items[action.payload.identifier]?.metadata, 'contact.displayName'), | |||
| ...(<MetadataEvent<ConversationMetadata>>action.payload).metadata, | |||
| contact: { | |||
There was a problem hiding this comment.
The pick line above its meant to fix this very issue 🤔 So having both is probably not good.
Bumps [react-window-infinite-loader](https://github.com/bvaughn/react-window-infinite-loader) from 1.0.5 to 1.0.7. - [Release notes](https://github.com/bvaughn/react-window-infinite-loader/releases) - [Changelog](https://github.com/bvaughn/react-window-infinite-loader/blob/master/CHANGELOG.md) - [Commits](https://github.com/bvaughn/react-window-infinite-loader/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [react-window](https://github.com/bvaughn/react-window) from 1.8.5 to 1.8.6. - [Release notes](https://github.com/bvaughn/react-window/releases) - [Changelog](https://github.com/bvaughn/react-window/blob/master/CHANGELOG.md) - [Commits](bvaughn/react-window@1.8.5...1.8.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump redux-starter-kit from 0.8.1 to 2.0.0 Bumps [redux-starter-kit](https://github.com/reduxjs/redux-starter-kit) from 0.8.1 to 2.0.0. - [Release notes](https://github.com/reduxjs/redux-starter-kit/releases) - [Commits](https://github.com/reduxjs/redux-starter-kit/commits) Signed-off-by: dependabot[bot] <support@github.com> * Switch to the redux toolkit instead Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christoph Pröschel <chris@airy.co>
Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 1.3.0 to 2.0.0. - [Release notes](https://github.com/webpack-contrib/style-loader/releases) - [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/style-loader@v1.3.0...v2.0.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 3.6.0 to 5.1.3. - [Release notes](https://github.com/webpack-contrib/css-loader/releases) - [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/css-loader@v3.6.0...v5.1.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump webpack-cli from 3.3.12 to 4.5.0 Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.12 to 4.5.0. - [Release notes](https://github.com/webpack/webpack-cli/releases) - [Changelog](https://github.com/webpack/webpack-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/webpack/webpack-cli/compare/v3.3.12...webpack-cli@4.5.0) Signed-off-by: dependabot[bot] <support@github.com> * Try and see if the anonymous pipe is at fault * ugprade bazel tools for cli 4.5 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christoph Pröschel <chris@airy.co>
* Bump ejs-compiled-loader from 1.1.0 to 3.0.0 Bumps [ejs-compiled-loader](https://github.com/bazilio91/ejs-compiled-loader) from 1.1.0 to 3.0.0. - [Release notes](https://github.com/bazilio91/ejs-compiled-loader/releases) - [Commits](bazilio91/ejs-compiled-loader@1.1...3.0.0) Signed-off-by: dependabot[bot] <support@github.com> * remove ejs compiled loader Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christoph Pröschel <chris@airy.co>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.18.0 to 4.19.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.19.0/packages/parser) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.10 to 7.13.12. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.13.12/packages/babel-preset-env) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [react-redux](https://github.com/reduxjs/react-redux) from 7.2.2 to 7.2.3. - [Release notes](https://github.com/reduxjs/react-redux/releases) - [Changelog](https://github.com/reduxjs/react-redux/blob/master/CHANGELOG.md) - [Commits](reduxjs/react-redux@v7.2.2...v7.2.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added docs for twilio source * added images for twilio * continued twilio sms source * added twilio sms * added whatsapp source * fixed sms channels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1306