Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1045] Automated testing of the web socket #1382

Merged
merged 7 commits into from
Mar 26, 2021
Merged

[#1045] Automated testing of the web socket #1382

merged 7 commits into from
Mar 26, 2021

Conversation

ogbeche77
Copy link
Contributor

Fixes #1045

@ogbeche77 ogbeche77 force-pushed the feature/1045-automated-test-of-the-web-soc branch from 60d30c3 to c1c19c5 Compare March 25, 2021 15:28
@pascal-holy pascal-holy mentioned this pull request Mar 25, 2021
Open
@ogbeche77 ogbeche77 marked this pull request as ready for review March 26, 2021 09:11
pascal-holy
pascal-holy reviewed Mar 26, 2021
View reviewed changes
integration/chat-plugin/BUILD Show resolved Hide resolved
integration/cypress.json Outdated Show resolved Hide resolved
integration/chat-plugin/websocket_test.spec.ts Outdated Show resolved Hide resolved
integration/chat-plugin/websocket_test.spec.ts Outdated Show resolved Hide resolved
frontend/chat-plugin/handles/index.ts Outdated Show resolved Hide resolved
integration/ui/create_tag.spec.ts Show resolved Hide resolved
pascal-holy
pascal-holy approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@pascal-holy pascal-holy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
We will keep improving with #1386
but currently, there are more important things to test 🎉

@ogbeche77 ogbeche77 merged commit b19e218 into develop Mar 26, 2021
@ogbeche77 ogbeche77 deleted the feature/1045-automated-test-of-the-web-soc branch March 26, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-holy pascal-holy pascal-holy approved these changes

@chrismatix chrismatix Awaiting requested review from chrismatix chrismatix is a code owner

@lucapette lucapette Awaiting requested review from lucapette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automated test of the Websocket
2 participants
@ogbeche77 @pascal-holy