Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1111] Customize Chat Plugin #1456

Merged
merged 17 commits into from
Apr 7, 2021
Merged

[#1111] Customize Chat Plugin #1456

merged 17 commits into from
Apr 7, 2021

Conversation

AitorAlgorta
Copy link
Contributor

closes #1111

@AitorAlgorta AitorAlgorta marked this pull request as draft April 1, 2021 14:11
@AitorAlgorta AitorAlgorta self-assigned this Apr 6, 2021
@AitorAlgorta AitorAlgorta marked this pull request as ready for review April 6, 2021 13:02
stayprodio
stayprodio previously approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@stayprodio stayprodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lucapette
lucapette previously approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but looking good!

frontend/chat-plugin/src/App.tsx Outdated Show resolved Hide resolved
frontend/chat-plugin/src/components/chat/index.tsx Outdated Show resolved Hide resolved
@AitorAlgorta AitorAlgorta dismissed stale reviews from lucapette and stayprodio via 724fcc2 April 6, 2021 16:00
@AitorAlgorta AitorAlgorta merged commit 25821c5 into develop Apr 7, 2021
@AitorAlgorta AitorAlgorta deleted the feature/1111-customize-chat-plugin branch April 7, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-holy pascal-holy pascal-holy approved these changes

@lucapette lucapette lucapette approved these changes

@stayprodio stayprodio stayprodio left review comments

@chrismatix chrismatix Awaiting requested review from chrismatix chrismatix is a code owner

@ogbeche77 ogbeche77 Awaiting requested review from ogbeche77

@AudreyKj AudreyKj Awaiting requested review from AudreyKj

Assignees

@AitorAlgorta AitorAlgorta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce themeConfig to the chatplugin
4 participants
@AitorAlgorta @lucapette @stayprodio @pascal-holy