Fix hot module replacement #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismatix
commented
Apr 7, 2021
| @@ -207,10 +207,10 @@ function allReducer( | |||
| ...state.items[action.payload.identifier], | |||
| metadata: { | |||
| // Ensure that there is always a display name present | |||
| ...(<MetadataEvent<ConversationMetadata>>action.payload).metadata, | |||
There was a problem hiding this comment.
This way of doing type assertions is outdated and conflicts with the babel typescript plugin
lucapette
previously approved these changes
Apr 8, 2021
| @@ -1,5 +1,5 @@ | |||
| export interface ConnectTwilioSmsRequestPayload { | |||
| sourceChannelId?: string; | |||
| sourceChannelId: string; | |||
chrismatix
changed the title
chrismatix
requested review from
AudreyKj,
ogbeche77,
AitorAlgorta and
stayprodio
AitorAlgorta
reviewed
Apr 8, 2021
| @@ -47,7 +77,7 @@ export class HttpClient { | |||
| try { | |||
| return await response.json(); | |||
| } catch { | |||
| // NOP | |||
| // NOOP | |||
|
@bitboxer please come back. See I fixed it 🙇 |
|
I am now working on recover but will happily switch back to airy if you can make your boss pay me 😉 . |
|
i always expected you to come back one day, but this was kind of fast. 😉
…On Thu, Apr 8, 2021 at 19:57 Bodo Tasche ***@***.***> wrote:
I am now working on recover <https://www.recoverapp.de/> but will happily
switch back to airy if you can make your boss pay me 😉 .
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1480 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFAL2LV64FTOLFL2RRU3VDTHXVCBANCNFSM42RCSERQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #387