Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#740] Uses components endpoint on service discovery #1549

Merged
merged 8 commits into from
Apr 15, 2021
Merged

[#740] Uses components endpoint on service discovery #1549

merged 8 commits into from
Apr 15, 2021

Conversation

paulodiniz
Copy link
Contributor

No description provided.

@paulodiniz paulodiniz changed the title [#740] - Uses components endpoint on service discovery [#740] Uses components endpoint on service discovery Apr 15, 2021
@paulodiniz paulodiniz marked this pull request as ready for review April 15, 2021 06:53
@paulodiniz paulodiniz force-pushed the feature/740-uses-components-endpoint-on-service-discovery branch from a208e06 to 1cb9555 Compare April 15, 2021 06:58
lucapette
lucapette suggested changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@lucapette lucapette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting as "request changes" as we have to clear the map before using it

AitorAlgorta
AitorAlgorta previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend code looks good :)

chrismatix
chrismatix previously approved these changes Apr 15, 2021
View reviewed changes
@paulodiniz paulodiniz enabled auto-merge (squash) April 15, 2021 12:56
AitorAlgorta
AitorAlgorta approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@AitorAlgorta AitorAlgorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE is good

@paulodiniz paulodiniz merged commit 6c2b0f7 into develop Apr 15, 2021
@paulodiniz paulodiniz deleted the feature/740-uses-components-endpoint-on-service-discovery branch April 15, 2021 14:52
@chrismatix chrismatix mentioned this pull request Apr 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AitorAlgorta AitorAlgorta AitorAlgorta approved these changes

@lucapette lucapette lucapette approved these changes

@chrismatix chrismatix Awaiting requested review from chrismatix

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulodiniz @lucapette @chrismatix @AitorAlgorta