[#1234] add old conversation header bar to core UI #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudreyKj
commented
Apr 20, 2021
| @@ -44,7 +44,7 @@ const ConversationListItem = (props: ConversationListItemProps) => { | |||
|
|
|||
| const participant = conversation.metadata.contact; | |||
| const unread = conversation.metadata.unreadCount > 0; | |||
| const currentConversationState = conversation.metadata.state; | |||
| const currentConversationState = conversation.metadata.state || 'OPEN'; | |||
There was a problem hiding this comment.
we need to add a check here because when a new conversation is created conversation.metadata.state is undefined
stayprodio
previously approved these changes
Apr 20, 2021
chrismatix
reviewed
Apr 20, 2021
| border-bottom: 5px var(--color-red-alert) solid; | ||
| } | ||
|
|
||
| .conversationStatus.open .openButton { |
There was a problem hiding this comment.
Are you sure that you need to prefix all of them with .conversationStatus? Because this is a css module there should already be an automatic prefix
There was a problem hiding this comment.
true! this is totally unnecessary, will fix!
AudreyKj
changed the title
stayprodio
approved these changes
Apr 20, 2021
AudreyKj
deleted the
feature/1523-add-old-conversation-header-bar-to-core-ui
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1523