-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3539] Helm installation on minikube is incorrect #3566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff @bilgeAiry 🎉
However the PR needs a rebase on top of the latest develop
because there are some conflicts.
@@ -51,7 +51,7 @@ The base URL for the [API](../../api/introduction.md) is the same to access the | |||
To customize your Minikube instance, you can adjust the `driver`, `cpus` and `memory` attributes in the following manner: | |||
|
|||
``` | |||
airy create --provider=minikube --provider-config driver=virtualbox,cpus=4,memory=8192 my-airy | |||
minikube -p airy-core start --driver=docker --cpus=3 --memory=7168 --container-runtime=containerd --ports=80:80 --extra-config=apiserver.service-node-port-range=1-65535 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to change this, as the airy
CLI also provides a way to customize the installation with the --provider-config
flags.
@ljupcovangelski review says review required after conflict resolve |
The edited line was wrong only changed driver to docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🎉
finally 👯♀️ |
Fix of the issue [#3539 ] - Updated the installation documentation for minikube and helm