Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3539] Helm installation on minikube is incorrect #3566

Merged
5 commits merged into from
Aug 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2022

Fix of the issue [#3539 ] - Updated the installation documentation for minikube and helm

chrismatix
chrismatix previously approved these changes Aug 10, 2022
Copy link
Contributor

@ljupcovangelski ljupcovangelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @bilgeAiry 🎉
However the PR needs a rebase on top of the latest develop because there are some conflicts.

@@ -51,7 +51,7 @@ The base URL for the [API](../../api/introduction.md) is the same to access the
To customize your Minikube instance, you can adjust the `driver`, `cpus` and `memory` attributes in the following manner:

```
airy create --provider=minikube --provider-config driver=virtualbox,cpus=4,memory=8192 my-airy
minikube -p airy-core start --driver=docker --cpus=3 --memory=7168 --container-runtime=containerd --ports=80:80 --extra-config=apiserver.service-node-port-range=1-65535
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to change this, as the airy CLI also provides a way to customize the installation with the --provider-config flags.

@chrismatix chrismatix changed the title 3539 helm installation on minikube is incorrect [#3539] helm installation on minikube is incorrect Aug 10, 2022
@ljupcovangelski ljupcovangelski changed the title [#3539] helm installation on minikube is incorrect [#3539] Helm installation on minikube is incorrect Aug 10, 2022
@ghost
Copy link
Author

ghost commented Aug 10, 2022

@ljupcovangelski review says review required after conflict resolve

Bilge Han Cakmak added 2 commits August 11, 2022 09:56
The edited line was wrong only changed driver to docker.
Copy link
Contributor

@ljupcovangelski ljupcovangelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@ghost ghost merged commit f37f44b into develop Aug 11, 2022
@ghost ghost deleted the 3539-helm-installation-on-minikube-is-incorrect branch August 11, 2022 09:29
@ghost
Copy link
Author

ghost commented Aug 11, 2022

finally 👯‍♀️

@ghost ghost self-assigned this Sep 7, 2022
@ghost ghost added the docs label Sep 7, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants