Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3671] Restructure backend directories #3672

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

chrismatix
Copy link
Contributor

resolves #3671

@github-actions github-actions bot added the chore label Sep 2, 2022
Copy link
Contributor

@ljupcovangelski ljupcovangelski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not break anything, but I recommend that we name the sub-directories inside the components directory as the actual name of the components:

  • admin -> api-admin
  • facebook -> sources-facebook
  • webhook -> integration-webhook

Until we actually rename the components. So that we don't cause any confusion on what is the name of the component.

Copy link
Contributor

@juan-sebastian juan-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks

@chrismatix chrismatix marked this pull request as ready for review September 2, 2022 11:47
@chrismatix chrismatix merged commit 888fa28 into develop Sep 2, 2022
@chrismatix chrismatix deleted the chore/3671-restructure-backend-dirs branch September 2, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure backend directories
3 participants