Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3758] Channels filter not appearing on the Inbox UI #3759

Merged
merged 4 commits into from
Sep 22, 2022

Conversation

AudreyKj
Copy link
Contributor

@AudreyKj AudreyKj commented Sep 22, 2022

closes #3758

Changes:

  • Fixed the bug of channels & sources filters not appearing on the Inbox UI, which was related to this change [#3609] Added catch for promises #3636
  • Improved experience by fixing the problem of not seeing sources which channels are disconnected in the filtering box (which results in a strange UX because disconnected channels appear in the Inbox)

@github-actions github-actions bot added the fix label Sep 22, 2022
@AudreyKj AudreyKj changed the title Channels filter not appearing on the Inbox UI [#3758] [#3758] Channels filter not appearing on the Inbox UI Sep 22, 2022
sources: channels.reduce<Set<string>>((acc, {source}) => {
acc.add(source);
sources: conversations.reduce<Set<string>>((acc, {channel}) => {
acc.add(channel.source);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the problem of not seeing sources which channels are disconnected in the filtering box

Copy link
Contributor

@stayprodio stayprodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AudreyKj AudreyKj merged commit 34d5572 into develop Sep 22, 2022
@AudreyKj AudreyKj deleted the bug/3758-channels-filter-not-appearing-on-inbox-ui branch September 22, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channels filter not appearing on the Inbox UI
2 participants