Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scannerが一部文字を無視する問題を修正 #769

Merged
merged 7 commits into from
Sep 2, 2024

Conversation

FineArchs
Copy link
Member

#766
再発防止のため、各項目が場合分けを完結させるよう強制するようにしています。

@FineArchs FineArchs marked this pull request as draft August 25, 2024 15:19
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/parser/scanner.ts 94.23% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/parser/scanner.ts 94.37% <94.23%> (+5.61%) ⬆️

... and 29 files with indirect coverage changes

@FineArchs FineArchs marked this pull request as ready for review August 25, 2024 15:24
src/parser/scanner.ts Outdated Show resolved Hide resolved
Co-authored-by: salano_ym <53254905+salano-ym@users.noreply.github.com>
src/parser/scanner.ts Outdated Show resolved Hide resolved
src/parser/scanner.ts Outdated Show resolved Hide resolved
@salano-ym
Copy link
Member

本題とはずれるけれど、this.stream.eofthis.stream.charがgetterなのが#732 と同じ理由であまり良くない?

src/parser/scanner.ts Outdated Show resolved Hide resolved
@FineArchs
Copy link
Member Author

https://github.com/aiscript-dev/aiscript/actions/runs/10644756798/job/29509847385?pr=769

let文でtrue, false, nullのキーワードが弾かれていないらしい(masterでも確認したのでこのPRが原因ではないはず)

@FineArchs
Copy link
Member Author

条件を満たしているのでマージします。

@FineArchs FineArchs merged commit 5490dfe into aiscript-dev:master Sep 2, 2024
4 checks passed
@FineArchs FineArchs deleted the fix-parser branch September 2, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants