Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using r = some_value in workflow triggers R integration, to ignore 'r =' / 'R =' - done #1011

Closed
Jassherrin opened this issue Apr 13, 2021 · 10 comments
Closed

Using r = some_value in workflow triggers R integration, to ignore 'r =' / 'R =' - done #1011

Jassherrin opened this issue Apr 13, 2021 · 10 comments
Assignees
@kensoh
Labels
feature

Comments

@Jassherrin
Copy link

The tagui runs as normal until the excel sheet. There are a bunch of things it needs to copy and it gets stuck coping at the same place. The command prompt shows no error and does not stop the process unless it is ctrl C'ed.

It keeps getting stuck at U15's r = clipboard().

keyboard [ctrl]g

keyboard [ctrl]a[delete]

keyboard U14[enter]

keyboard [ctrl]c

q = clipboard()

keyboard [ctrl]g

keyboard [ctrl]a[delete]

keyboard U15[enter]

keyboard [ctrl]c

r = clipboard()

keyboard [ctrl]g

keyboard [ctrl]a[delete]

keyboard U16[enter]

keyboard [ctrl]c

s = clipboard()
@kensoh
Copy link
Member

kensoh commented Apr 13, 2021

Hi @Jassherrin can you attach the log files in tagui\src\tagui.sikuli here?

The logs will share more info what could have gone wrong. Haven't come across this issue before from users.

@kensoh kensoh self-assigned this Apr 13, 2021
@kensoh kensoh added the query label Apr 13, 2021
@kensoh kensoh changed the title Tagui stuck TagUI stucks on reading from clipboard() helper function - pending logs and checks Apr 13, 2021
@Jassherrin
Copy link
Author

tagui.sikuli.zip

@kensoh
Copy link
Member

kensoh commented Apr 13, 2021 •
edited
Loading

Hi @Jassherrin from the logs it looks like everything works correctly. It might be [ctrl]c end up killing TagUI because that is the shortcut to kill TagUI if your focus at the moment is on TagUI and not other apps. Will you be able to join the weekly Zoom call this Thursday from 4-5pm? we can look further on the call. I cannot find anything wrong with the logs and your workflow.

[tagui] INPUT  - [117] keyboard U15[enter]
[tagui] ACTION - keyboard U15[enter]
[log]  TYPE "U15#ENTER."
[tagui] OUTPUT - [117] SUCCESS

[tagui] INPUT  - [118] keyboard [ctrl]c
[tagui] ACTION - keyboard [ctrl]c
[log] ( Ctrl )  TYPE "c"
[tagui] OUTPUT - [118] SUCCESS

[tagui] FINISH - stopped listening
IDE terminated: returned: 0

@kensoh kensoh changed the title TagUI stucks on reading from clipboard() helper function - pending logs and checks TagUI stucks on reading from clipboard() helper function - pending Zoom call Apr 13, 2021
@kensoh kensoh changed the title TagUI stucks on reading from clipboard() helper function - pending Zoom call TagUI stucks on reading from clipboard() helper function - pending Thu Zoom call Apr 13, 2021
@Jassherrin
Copy link
Author

I'll join the zoom call tomorrow. Thanks.

@Jassherrin
Copy link
Author

Hello could we meet around 4.30 or 5pm?

@kensoh
Copy link
Member

kensoh commented Apr 14, 2021

Hi @Jassherrin 430pm ok, if you join at 445pm ok too.

@Jassherrin Jassherrin reopened this Apr 20, 2021
@Jassherrin
Copy link
Author

The problem was with the variable r. Changing it fixes the issue.

@kensoh
Copy link
Member

kensoh commented Apr 20, 2021

Thanks Sherrin for closing the issue!

Adding on, yes, r = some value will be interpreted by TagUI as trying to run the R integration with r some commands

I'll reopen the issue for the time being, and see if we can add some safeguards so that users won't run into this again.

For eg, maybe ignore r = or r= statements to be R integration commands, since they are more like defining variable.

@kensoh kensoh reopened this Apr 20, 2021
@kensoh kensoh changed the title TagUI stucks on reading from clipboard() helper function - pending Thu Zoom call TagUI stucks on reading from clipboard() helper function - to ignore 'r =' / 'r=' Apr 20, 2021
@kensoh kensoh added feature and removed query labels Apr 20, 2021
@kensoh kensoh changed the title TagUI stucks on reading from clipboard() helper function - to ignore 'r =' / 'r=' TagUI stucks on reading from clipboard() helper function - to ignore 'r =' May 25, 2021
@kensoh kensoh changed the title TagUI stucks on reading from clipboard() helper function - to ignore 'r =' TagUI stucks on reading from clipboard() helper function - to ignore 'r =' / 'R =' May 25, 2021
kensoh added a commit that referenced this issue May 25, 2021
@kensoh
#1011 - false-positive for r integration
731a735
@kensoh
Copy link
Member

kensoh commented May 25, 2021

Above commit fixes this. Users can download the latest copy of TagUI with this fix and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip

In the next release, this will become part of the packaged zip files.

@kensoh kensoh changed the title TagUI stucks on reading from clipboard() helper function - to ignore 'r =' / 'R =' using r = 1 triggers R integraton, to ignore 'r =' / 'R =' - done May 25, 2021
@kensoh kensoh changed the title using r = 1 triggers R integraton, to ignore 'r =' / 'R =' - done Using r = some_value in workflow triggers R integraton, to ignore 'r =' / 'R =' - done May 25, 2021
@kensoh kensoh changed the title Using r = some_value in workflow triggers R integraton, to ignore 'r =' / 'R =' - done Using r = some_value in workflow triggers R integration, to ignore 'r =' / 'R =' - done May 25, 2021
@kensoh
Copy link
Member

kensoh commented Jun 18, 2021

Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0

@kensoh kensoh closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kensoh kensoh

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kensoh @Jassherrin